From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: ChangeLog is generated from gitlog now.
Date: Sat, 24 Jan 2015 19:55:32 +0100 [thread overview]
Message-ID: <54C3EAA4.3010008@gmail.com> (raw)
In-Reply-To: <20150124213749.52165c07@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]
On 24.01.2015 19:37, Andrei Borzenkov wrote:
> В Sat, 24 Jan 2015 17:33:44 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>
>> It's generated only on creation of dist archive.
>> This also has implications to the git commit message format used.
>> Now git commit message follows standard git commit writing rules rather
>> than one-off rules which resulted from CSV->SVN->BZR->Git transitions.
>>
>
>> +ChangeLog: FORCE
>> + if test -d $(top_srcdir)/.git; then \
>> + $(gitlog_to_changelog) --srcdir=$(top_srcdir) --since=$(changelog_start_date) > '$@.tmp'; \
>> + rm -f '$@'; mv '$@.tmp' '$@'; \
>> + fi
>> +
>> +EXTRA_DIST += ChangeLog ChangeLog-2015
>
>
> This breaks make dist from git checkout, where repository is not
> available. May be empty ChangeLog should be created by autogen.sh.
>
Would this patch fix your issue?
diff --git a/Makefile.am b/Makefile.am
index df0a728..a9f5780 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -447,6 +447,8 @@ ChangeLog: FORCE
if test -d $(top_srcdir)/.git; then \
$(gitlog_to_changelog) --srcdir=$(top_srcdir)
--since=$(changelog_start_date) > '$@.tmp'; \
rm -f '$@'; mv '$@.tmp' '$@'; \
+ else \
+ touch $@; \
fi
EXTRA_DIST += ChangeLog ChangeLog-2015
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2015-01-24 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 16:33 ChangeLog is generated from gitlog now Vladimir 'φ-coder/phcoder' Serbinenko
2015-01-24 18:37 ` Andrei Borzenkov
2015-01-24 18:55 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-01-24 19:07 ` Andrei Borzenkov
2015-01-24 19:18 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C3EAA4.3010008@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).