From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YIMdj-00026b-QW for mharc-grub-devel@gnu.org; Mon, 02 Feb 2015 14:26:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIMdh-00026R-6L for grub-devel@gnu.org; Mon, 02 Feb 2015 14:26:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIMde-0001eZ-14 for grub-devel@gnu.org; Mon, 02 Feb 2015 14:26:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIMdd-0001eV-PH for grub-devel@gnu.org; Mon, 02 Feb 2015 14:26:25 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t12JQNQk031716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 2 Feb 2015 14:26:23 -0500 Received: from [10.16.186.145] (prarit-guest.khw.lab.eng.bos.redhat.com [10.16.186.145]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t12JQMZa003338; Mon, 2 Feb 2015 14:26:22 -0500 Message-ID: <54CFCF5E.6040606@redhat.com> Date: Mon, 02 Feb 2015 14:26:22 -0500 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131028 Thunderbird/17.0.10 MIME-Version: 1.0 To: David Michael Subject: Re: [PATCH] Add a module for retrieving SMBIOS information References: <87r3u92hln.fsf@gmail.com> <54CF5D70.4020904@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: The development of GNU GRUB , Raghuraman Thirumalairajan , Andrei Borzenkov , Rajat Jain , Sanjay Jain , Stu Grossman X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 19:26:30 -0000 On 02/02/2015 12:09 PM, David Michael wrote: > On Mon, Feb 2, 2015 at 6:20 AM, Prarit Bhargava wrote: >> On 02/01/2015 09:05 PM, David Michael wrote: >>> * grub-core/commands/i386/smbios.c: New file. >>> * grub-core/Makefile.core.def (smbios): New module. >>> * docs/grub.texi (smbios): New node. >>> (Command-line and menu entry commands): Add a menu entry for smbios. >>> --- >>> >>> Hi, >>> >>> There was some interest on help-grub about supporting SMBIOS access >>> upstream. >> >> OOC, why? Why would you need to do this? I'm certainly not against doing this >> but just wondering exactly why you want to do this. > > The thread on grub-help asked about booting particular kernel versions > off a hot-pluggable drive based on the detected hardware, which this > would allow. > > I originally wrote it to change what options are available based on > whether a disk is being booted physically or virtually. Since QEMU > makes it easy to add SMBIOS entries on the command line, I've also > been using it for random tweaks like showing a vga_text boot menu > instead of gfxterm when running QEMU with "-display curses". > Ah interesting David -- and good job on getting the efi.smbios stuff in there too as that's an easy thing to miss. I'll take a closer look ... P. > Thanks. > > David >