From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YJ0TG-0006JJ-Kg for mharc-grub-devel@gnu.org; Wed, 04 Feb 2015 08:58:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ0TE-0006F8-6K for grub-devel@gnu.org; Wed, 04 Feb 2015 08:58:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ0TA-0007qY-6B for grub-devel@gnu.org; Wed, 04 Feb 2015 08:58:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ0T9-0007qO-Vf for grub-devel@gnu.org; Wed, 04 Feb 2015 08:58:16 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t14DwDK6010069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Feb 2015 08:58:13 -0500 Received: from [10.16.186.145] (prarit-guest.khw.lab.eng.bos.redhat.com [10.16.186.145]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t14DwC9k018532; Wed, 4 Feb 2015 08:58:12 -0500 Message-ID: <54D22573.70702@redhat.com> Date: Wed, 04 Feb 2015 08:58:11 -0500 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131028 Thunderbird/17.0.10 MIME-Version: 1.0 To: David Michael Subject: Re: [PATCH] Add a module for retrieving SMBIOS information References: <87r3u92hln.fsf@gmail.com> <54CF5D70.4020904@redhat.com> <54CFCF5E.6040606@redhat.com> <54D0E390.9060208@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: The development of GNU GRUB , Raghuraman Thirumalairajan , Andrei Borzenkov , Rajat Jain , Sanjay Jain , Stu Grossman X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2015 13:58:21 -0000 On 02/03/2015 01:41 PM, David Michael wrote: > On Tue, Feb 3, 2015 at 10:04 AM, Prarit Bhargava wrote: >> On 02/02/2015 02:26 PM, Prarit Bhargava wrote: >>> >>> >>> On 02/02/2015 12:09 PM, David Michael wrote: >>>> On Mon, Feb 2, 2015 at 6:20 AM, Prarit Bhargava wrote: >>>>> On 02/01/2015 09:05 PM, David Michael wrote: >>>>>> * grub-core/commands/i386/smbios.c: New file. >>>>>> * grub-core/Makefile.core.def (smbios): New module. >>>>>> * docs/grub.texi (smbios): New node. >>>>>> (Command-line and menu entry commands): Add a menu entry for smbios. >>>>>> --- >>>>>> >>>>>> Hi, >>>>>> >>>>>> There was some interest on help-grub about supporting SMBIOS access >>>>>> upstream. >>>>> >>>>> OOC, why? Why would you need to do this? I'm certainly not against doing this >>>>> but just wondering exactly why you want to do this. >>>> >>>> The thread on grub-help asked about booting particular kernel versions >>>> off a hot-pluggable drive based on the detected hardware, which this >>>> would allow. >>>> >>>> I originally wrote it to change what options are available based on >>>> whether a disk is being booted physically or virtually. Since QEMU >>>> makes it easy to add SMBIOS entries on the command line, I've also >>>> been using it for random tweaks like showing a vga_text boot menu >>>> instead of gfxterm when running QEMU with "-display curses". >>>> >>> >>> Ah interesting David -- and good job on getting the efi.smbios stuff in there >>> too as that's an easy thing to miss. I'll take a closer look ... >>> >> >> FWIW, I think it looks fine and it definitely has a valid use case. I'd suggest >> that you update the description with Rajat's comment. > > Okay, to be clear, by "description" here do you mean to put the use > case in the commit message? Yes, I find it useful to note the use case. Later on if someone wants to make a change to the module we'll know exactly why it was created. ^^^ The above is IMO and has become a sort of standard for other projects. The maintainer here may not like it ... but a few extra sentences in the commit message can't hurt anything ;) > >> One odd thing in the patch (and it may be something weird on my end that I've >> never seen before). When I saved and applied your patch via 'git am', the patch >> contained a few "^L" lines. > > Yes, I used formfeeds to follow the GNU coding standards document when > I first wrote the module. I'll take them out of the updated patch. Thanks! P. > > Thanks. > > David >