From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YJKAD-0003Iu-8N for mharc-grub-devel@gnu.org; Thu, 05 Feb 2015 06:00:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJKAA-0003In-NI for grub-devel@gnu.org; Thu, 05 Feb 2015 05:59:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJKA6-00009b-DF for grub-devel@gnu.org; Thu, 05 Feb 2015 05:59:58 -0500 Received: from smtp.citrix.com ([66.165.176.89]:10427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJKA6-000085-7S for grub-devel@gnu.org; Thu, 05 Feb 2015 05:59:54 -0500 X-IronPort-AV: E=Sophos;i="5.09,523,1418083200"; d="scan'208";a="223352962" Message-ID: <54D34D19.3080800@citrix.com> Date: Thu, 5 Feb 2015 10:59:37 +0000 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Jan Beulich Subject: Re: [PATCH 00/18] x86: multiboot2 protocol support References: <1422640462-28103-1-git-send-email-daniel.kiper@oracle.com> <54CF5161020000780005BC77@mail.emea.novell.com> <20150203171414.GK29167@olila.local.net-space.pl> <54D1E091.1080109@citrix.com> <54D1F9AC020000780005CB6F@mail.emea.novell.com> In-Reply-To: <54D1F9AC020000780005CB6F@mail.emea.novell.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.89 Cc: Juergen Gross , grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, phcoder@gmail.com, Daniel Kiper , roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2015 10:59:59 -0000 On 04/02/15 09:51, Jan Beulich wrote: >>>> On 04.02.15 at 10:04, wrote: >> On 03/02/2015 17:14, Daniel Kiper wrote: >>> On Mon, Feb 02, 2015 at 09:28:49AM +0000, Jan Beulich wrote: >>>>>>> On 30.01.15 at 18:54, wrote: >>>>> - xen.efi build will not so strongly depend >>>>> on a given GCC and binutils version. >>>> While I can see the possibility of making the binutils version >>>> dependency go away (by manually creating the PE header), I can't >>>> see how you'd overcome the gcc one: The MS calling convention >>>> support is still going to be needed (not having looked at the patches >>> Right, I forgot about that one. >>> >>>> themselves yet, I can't see myself accepting the introduction of >>>> stubs to convert between calling conventions). >> How about __attribute__((ms_abi)) ? It would appear to exist for this >> purpose. > But that's the point: Older compilers don't support it. And with > compilers supporting it we need no stubs. If the use of __attribute__((ms_abi)) was suitably contained within a #ifdef CONFIG_EFI, I don't see an problem. CONFIG_EFI could derive primarily from a compiler version check if we don't wish to force a minimum newer version of gcc. One way or another, a newer set of tools is needed to build EFI support, and a binary capable of both legacy and efi boot is quite desirable to have. ~Andrew