From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YbWAt-000352-7P for mharc-grub-devel@gnu.org; Fri, 27 Mar 2015 11:27:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbWAr-00034u-Mj for grub-devel@gnu.org; Fri, 27 Mar 2015 11:27:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbWAq-0003NQ-Cw for grub-devel@gnu.org; Fri, 27 Mar 2015 11:27:53 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:38740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbWAq-0003NC-6J for grub-devel@gnu.org; Fri, 27 Mar 2015 11:27:52 -0400 Received: by wibgn9 with SMTP id gn9so36008734wib.1 for ; Fri, 27 Mar 2015 08:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=NI2Ogbvc1slQH6HtPQCsqUR/fyejFUZYQZ9ZC6/k23w=; b=tNTVVACyHgETBYET9M/tgrZrxjPe0kwKIZGdojQ/jA+UgGDoFHx6mU1Rn1mPR0hNis qj3j4j/Xzht7D9uKxgeNcDSegbf+3213520ExUdJBEirg0EmyWHGAOPTY3VV1xKwAQXQ VTIhZCf+2hspCPJkiclXmrDYO6YC4m6Q+/+8N4nTXvZEoj46HCHeysKoqlJhUcZKd993 TZkYwfupLli7IVDEY0aJ7MLtyb9VQ8N9+MpYKJhjJqW+J+v4+p3HTCuTuGt02X0l0aLw IdLZb4WDyaGJSVImbkIKxvEmpYGThYxCikA4yOCg4Sx+IRSCtHtEXOQLeSrCH/nIV+46 Hnsg== X-Received: by 10.180.13.146 with SMTP id h18mr57023657wic.73.1427470071592; Fri, 27 Mar 2015 08:27:51 -0700 (PDT) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id hi6sm3279589wjc.34.2015.03.27.08.27.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2015 08:27:50 -0700 (PDT) Message-ID: <55157700.9080507@gmail.com> Date: Fri, 27 Mar 2015 16:28:00 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: Query about GRUB_ENABLE_CRYPTODISK References: <5486EC88.1010908@zen.co.uk> <20141209212740.4d1f3ded@opensuse.site> <54877968.8030508@zen.co.uk> <54878575.6090501@zen.co.uk> <20141210062558.15524434@opensuse.site> In-Reply-To: <20141210062558.15524434@opensuse.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 15:27:54 -0000 Please commit this patch On 10.12.2014 04:25, Andrei Borzenkov wrote: > В Tue, 09 Dec 2014 23:27:49 +0000 > Barry Jackson пишет: > >> On 09/12/14 22:36, Barry Jackson wrote: >>> On 09/12/14 18:27, Andrei Borzenkov wrote: >>>> В Tue, 09 Dec 2014 12:35:20 +0000 >>>> Barry Jackson пишет: >>>> >>>>> Hello, >>>>> In Mageia it has been proposed that GRUB_ENABLE_CRYPTODISK=y be made the >>>>> default setting in /etc/default/grub for all installations, whether they >>>>> use encryption or not. >>>> >>>> The discussion happens every now and then. >>>> >>>> http://lists.gnu.org/archive/html/grub-devel/2013-12/msg00112.html >>> >>> OK, thanks for the link. >>> >>> In the case of Mageia the default installation puts everything required >>> by grub under /boot, so AFAICT this should not cause a problem. >> >> ... but it does. >> >> I found time to do some testing, and adding it to the config on a system >> with no encryption at all causes an error message: >> error: device name required. >> >> this seems to be triggered by this line which grub-mkconfig adds to >> grub.cfg: >> >> cryptomount -u >> > > Does patch below help? > > From: Andrei Borzenkov > Subject: [PATCH] do not emit cryptomount without crypto UUID > > --- > util/grub-mkconfig_lib.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in > index 29ef865..60b31ca 100644 > --- a/util/grub-mkconfig_lib.in > +++ b/util/grub-mkconfig_lib.in > @@ -145,7 +145,7 @@ prepare_grub_to_access_device () > done > > if [ x$GRUB_ENABLE_CRYPTODISK = xy ]; then > - for uuid in "`"${grub_probe}" --device $@ --target=cryptodisk_uuid`"; do > + for uuid in `"${grub_probe}" --device $@ --target=cryptodisk_uuid`; do > echo "cryptomount -u $uuid" > done > fi >