From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YbWMn-0005kt-OF for mharc-grub-devel@gnu.org; Fri, 27 Mar 2015 11:40:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbWMk-0005km-90 for grub-devel@gnu.org; Fri, 27 Mar 2015 11:40:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbWMg-0008LC-5W for grub-devel@gnu.org; Fri, 27 Mar 2015 11:40:10 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:33877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbWMf-0008JG-U2 for grub-devel@gnu.org; Fri, 27 Mar 2015 11:40:06 -0400 Received: by wgs2 with SMTP id 2so103658718wgs.1 for ; Fri, 27 Mar 2015 08:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=cBkqjyCJII76pFLFUqVDucP2Pgkcldg0xSK27CRZk5E=; b=AE3teztCKTOz6Bp4fhBr8TueIMAiLeWA9fU7zmYPVyfSRIXmq0j0ql6fkMWDTWKJRb K/gJvgvr9j8aQm8b8dwcB0RW7XbEKpsUVjUbaI5PQmyv4dsoAt5dGbXvNz3QKQ7+DIoN D/Lt5j5TWTnMPe3Q+si6Y5FNTkPezc10H566A6/esNOqwEPXMgTaiqr2p7wtTUsdkhd9 +5eXa0wigEKYL9ahPF/j4CLdGC02UHlXiX/9SNo3nQsXo2T9sVSCQL2XlPoNj1ttqwpA 2eY21SjM5Lua9L/fp2D+Ds+nACe/rJiV+QwV8EfB614RnvwxPj+u+419Yst8OROwc7gH 2vJQ== X-Received: by 10.180.104.7 with SMTP id ga7mr13521164wib.37.1427470804932; Fri, 27 Mar 2015 08:40:04 -0700 (PDT) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id fo8sm3326821wib.14.2015.03.27.08.40.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2015 08:40:04 -0700 (PDT) Message-ID: <551579DE.8040505@gmail.com> Date: Fri, 27 Mar 2015 16:40:14 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH v2] grub-install: Install PV Xen binaries into the upstream specified path References: <1414099727-22463-1-git-send-email-ijc@hellion.org.uk> In-Reply-To: <1414099727-22463-1-git-send-email-ijc@hellion.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 15:40:12 -0000 On 23.10.2014 23:28, Ian Campbell wrote: > Upstream have defined a specification for where guests ought to place their > xenpv grub binaries in order to facilitate chainloading from a stage 1 grub > loaded from dom0. > > http://xenbits.xen.org/docs/unstable-staging/misc/x86-xenpv-bootloader.html > > The spec calls for installation into /boot/xen/pvboot-i386.elf or > /boot/xen/pvboot-x86_64.elf. > > Signed-off-by: Ian Campbell > > --- > v2: Respect bootdir, create /boot/xen as needed. > --- > util/grub-install.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/util/grub-install.c b/util/grub-install.c > index 70f514c..7a7734e 100644 > --- a/util/grub-install.c > +++ b/util/grub-install.c > @@ -1979,6 +1979,28 @@ main (int argc, char *argv[]) > } > break; > > + case GRUB_INSTALL_PLATFORM_I386_XEN: > + { > + char *path = grub_util_path_concat (2, bootdir, "xen"); > + char *dst = grub_util_path_concat (2, path, "pvboot-i386.elf"); > + grub_install_mkdir_p (path); > + grub_install_copy_file (imgfile, dst, 1); > + free (dst); > + free (path); > + } > + break; > + > + case GRUB_INSTALL_PLATFORM_X86_64_XEN: > + { > + char *path = grub_util_path_concat (2, bootdir, "xen"); Bootdir is not necessarily /boot. We also might want to specify xen dir to e.g. /mnt/ext2/boot/xen while still keeping GRUB itself in /boot/grub. Can you update patch to allow separate specification of bootdir and xendir? > + char *dst = grub_util_path_concat (2, path, "pvboot-x86_64.elf"); > + grub_install_mkdir_p (path); > + grub_install_copy_file (imgfile, dst, 1); > + free (dst); > + free (path); > + } > + break; > + > case GRUB_INSTALL_PLATFORM_MIPSEL_LOONGSON: > case GRUB_INSTALL_PLATFORM_MIPSEL_QEMU_MIPS: > case GRUB_INSTALL_PLATFORM_MIPS_QEMU_MIPS: > @@ -1987,8 +2009,6 @@ main (int argc, char *argv[]) > case GRUB_INSTALL_PLATFORM_MIPSEL_ARC: > case GRUB_INSTALL_PLATFORM_ARM_UBOOT: > case GRUB_INSTALL_PLATFORM_I386_QEMU: > - case GRUB_INSTALL_PLATFORM_I386_XEN: > - case GRUB_INSTALL_PLATFORM_X86_64_XEN: > grub_util_warn ("%s", > _("WARNING: no platform-specific install was performed")); > break; >