[PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c

[PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c

[Fu Wei]

       Reason: (1)we don't need the check, actually
               (2)it is a prerequisite for multiboot support

Signed-off-by: Fu Wei <fu.wei@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 grub-core/loader/arm64/linux.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c
index 987f5b9..e9e9a29 100644
--- a/grub-core/loader/arm64/linux.c
+++ b/grub-core/loader/arm64/linux.c
@@ -185,13 +185,6 @@ grub_cmd_devicetree (grub_command_t cmd __attribute__ ((unused)),
   void *blob = NULL;
   int size;
 
-  if (!loaded)
-    {
-      grub_error (GRUB_ERR_BAD_ARGUMENT,
-		  N_("you need to load the kernel first"));
-      return GRUB_ERR_BAD_OS;
-    }
-
   if (argc != 1)
     return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));
 
-- 
1.8.3.1

Re: [PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On 18.12.2014 19:06, Fu Wei wrote:
>        Reason: (1)we don't need the check, actually
>                (2)it is a prerequisite for multiboot support
> 
That one is problematic. Normally execution of any kernel-loading
commands like linux resets the boot context. Exceptions are drivemap,
sendkey, acpi and memory map commands, somewhat unfortunately. I'm on
the edge as to whether we should extend this behaviour to other commands.
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  grub-core/loader/arm64/linux.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c
> index 987f5b9..e9e9a29 100644
> --- a/grub-core/loader/arm64/linux.c
> +++ b/grub-core/loader/arm64/linux.c
> @@ -185,13 +185,6 @@ grub_cmd_devicetree (grub_command_t cmd __attribute__ ((unused)),
>    void *blob = NULL;
>    int size;
>  
> -  if (!loaded)
> -    {
> -      grub_error (GRUB_ERR_BAD_ARGUMENT,
> -		  N_("you need to load the kernel first"));
> -      return GRUB_ERR_BAD_OS;
> -    }
> -
>    if (argc != 1)
>      return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));
>  
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]