From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 1/2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON`
Date: Tue, 02 Jun 2015 18:45:19 +0200 [thread overview]
Message-ID: <556DDD9F.7030605@gmail.com> (raw)
In-Reply-To: <1432835841.3378.47.camel@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On 28.05.2015 19:57, Paul Menzel wrote:
> Date: Thu, 28 May 2015 19:14:19 +0200
>
> Instead of hard coding `2` and `4` use the macros defined already at the
> top of the file.
Splitting this and next patch makes absolutely no sense. If your changes
makes formatting of the changes line ugly, change formatting in the same
time unless it pollutes the view too much.
> ---
> grub-core/disk/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c
> index 7f75724..0825998 100644
> --- a/grub-core/disk/ahci.c
> +++ b/grub-core/disk/ahci.c
> @@ -552,7 +552,7 @@ grub_ahci_pciinit (grub_pci_device_t dev,
> adevs[i]->hba->ports[adevs[i]->port].sata_error);
>
> adevs[i]->hba->ports[adevs[i]->port].command
> - = (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 << 28) | 2 | 4;
> + = (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 << 28) | GRUB_AHCI_HBA_PORT_CMD_SPIN_UP | GRUB_AHCI_HBA_PORT_CMD_POWER_ON;
>
> /* struct grub_disk_ata_pass_through_parms parms2;
> grub_memset (&parms2, 0, sizeof (parms2));
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
prev parent reply other threads:[~2015-06-02 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 17:57 [PATCH 1/2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON` Paul Menzel
2015-05-28 18:03 ` [PATCH 2/2] disk/ahci.c: Wrap too long line Paul Menzel
2015-05-31 6:28 ` Andrei Borzenkov
2015-06-07 9:04 ` [PATCH v2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON` Paul Menzel
2015-06-12 6:44 ` Andrei Borzenkov
2015-06-02 16:43 ` [PATCH 2/2] disk/ahci.c: Wrap too long line Vladimir 'φ-coder/phcoder' Serbinenko
2015-06-02 16:45 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556DDD9F.7030605@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).