From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YzpJe-0008N5-P4 for mharc-grub-devel@gnu.org; Tue, 02 Jun 2015 12:45:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzpJb-0008DP-EF for grub-devel@gnu.org; Tue, 02 Jun 2015 12:45:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzpJa-0005mE-Bx for grub-devel@gnu.org; Tue, 02 Jun 2015 12:45:23 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:36359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzpJa-0005m2-4x for grub-devel@gnu.org; Tue, 02 Jun 2015 12:45:22 -0400 Received: by wibdq8 with SMTP id dq8so65003927wib.1 for ; Tue, 02 Jun 2015 09:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=DdZE1Vq69BcL2wOL3CUv7eNcEGxDGH2oezMLfmLUIlc=; b=0VDBMF9ooYRmhcfrCOAC5X4hvd59RBWPPBZfeKnTJLuMrdkEKDTYU0kmXoRD1AHH9/ QH4Jooteb9t1eOhgP7ZDg6rtJRS3gz+2usL/yJOOfUBBe8KUwO8BTZC4rOWEa7NlQosx 8QPVtKRFLmlMvSDFhooHCtHy+FID1BKNRa4gNSo+fyP/AaIzem6BwVFARQTsoEVM1Z6x c/TVXAJ4p4OfPWTy5zxPZ/Mx8libC8fpPy0vmDQJ8n5GSMPm0VhZ7t37n1YIeWNvBRT/ iYTge1A9k5Ta0TQnt/TpVZ1iTk/kz5Zyiq9iInvQ3SrhcZ2PIYAjDS9XJGPbBYTA8f+M 2WXQ== X-Received: by 10.194.23.197 with SMTP id o5mr53005212wjf.75.1433263521505; Tue, 02 Jun 2015 09:45:21 -0700 (PDT) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id o4sm878163wib.5.2015.06.02.09.45.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jun 2015 09:45:20 -0700 (PDT) Message-ID: <556DDD9F.7030605@gmail.com> Date: Tue, 02 Jun 2015 18:45:19 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 1/2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON` References: <1432835841.3378.47.camel@users.sourceforge.net> In-Reply-To: <1432835841.3378.47.camel@users.sourceforge.net> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Fb0fVPafuB8PlgGVLesJ5vin3pkJ05npp" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 16:45:24 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Fb0fVPafuB8PlgGVLesJ5vin3pkJ05npp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28.05.2015 19:57, Paul Menzel wrote: > Date: Thu, 28 May 2015 19:14:19 +0200 >=20 > Instead of hard coding `2` and `4` use the macros defined already at th= e > top of the file. Splitting this and next patch makes absolutely no sense. If your changes makes formatting of the changes line ugly, change formatting in the same time unless it pollutes the view too much. > --- > grub-core/disk/ahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c > index 7f75724..0825998 100644 > --- a/grub-core/disk/ahci.c > +++ b/grub-core/disk/ahci.c > @@ -552,7 +552,7 @@ grub_ahci_pciinit (grub_pci_device_t dev, > adevs[i]->hba->ports[adevs[i]->port].sata_error); > =20 > adevs[i]->hba->ports[adevs[i]->port].command > - =3D (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (= 1 << 28) | 2 | 4; > + =3D (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (= 1 << 28) | GRUB_AHCI_HBA_PORT_CMD_SPIN_UP | GRUB_AHCI_HBA_PORT_CMD_POWER_= ON; > =20 > /* struct grub_disk_ata_pass_through_parms parms2; > grub_memset (&parms2, 0, sizeof (parms2)); >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --Fb0fVPafuB8PlgGVLesJ5vin3pkJ05npp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlVt3aAACgkQmBXlbbo5nOsgUwD/c6Gk8SM0Xq1So7JCVmDf4YaR x67dZ+Y/1fYbaqK53+0BAJM2tK9LWSzKHxzv3iosPTEkrErbyoC8j7DlChuYfvkx =gqH8 -----END PGP SIGNATURE----- --Fb0fVPafuB8PlgGVLesJ5vin3pkJ05npp--