From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Z9aQ8-0001xX-0k for mharc-grub-devel@gnu.org; Mon, 29 Jun 2015 10:52:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9aQ0-0001kg-Fp for grub-devel@gnu.org; Mon, 29 Jun 2015 10:52:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9aPw-0007bx-Gd for grub-devel@gnu.org; Mon, 29 Jun 2015 10:52:20 -0400 Received: from johnlane.plus.com ([212.159.104.145]:64428 helo=sodium.amajohn.co.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9aPw-0007b2-AC for grub-devel@gnu.org; Mon, 29 Jun 2015 10:52:16 -0400 Received: by sodium.amajohn.co.uk (Postfix, from userid 1000) id 5D0314C; Mon, 29 Jun 2015 15:52:14 +0100 (BST) Received: from [10.0.200.1] (hydrogen.amajohn.co.uk [10.0.200.1]) by sodium.amajohn.co.uk (Postfix) with ESMTPSA id E33A229 for ; Mon, 29 Jun 2015 15:52:13 +0100 (BST) Message-ID: <55915B9D.2070304@jelmail.com> Date: Mon, 29 Jun 2015 15:52:13 +0100 From: John Lane User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH 5/5] Cryptomount support for hyphens in UUID References: <1435588260-29456-1-git-send-email-grub@jelmail.com> <1435588260-29456-6-git-send-email-grub@jelmail.com> In-Reply-To: <1435588260-29456-6-git-send-email-grub@jelmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Outbound-Checked: Yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 212.159.104.145 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 14:52:26 -0000 This revised patch uses a compare function. It doesn't modify the input supplied by the user. There are 3 places where UUIDs are compared: 1. when a crypto disk is referenced as a (cryptouuid/...) #cryotodisk.c grub_cryptodisk_open 2. when the -u argument is given to cryptomount it checks by the uuid that the device isn't already mounted #cryptodisk.c grub_cryptodisk_get_by_uuid 3. when locating a device by uuid it compares the given uuid with the LUKS header #luks.c configure_ciphers