From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: Andrei Borzenkov <arvidjaar@gmail.com>,
Daniel Kiper <daniel.kiper@oracle.com>
Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org,
ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
andrew.cooper3@citrix.com, roy.franz@linaro.org,
ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com,
xen-devel@lists.xenproject.org, qiaowei.ren@intel.com,
richard.l.maliszewski@intel.com, gang.wei@intel.com,
fu.wei@linaro.org
Subject: Re: [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices argument
Date: Wed, 15 Jul 2015 19:50:51 +0200 [thread overview]
Message-ID: <55A69D7B.50702@gmail.com> (raw)
In-Reply-To: <20150530082542.1fc95f55@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On 30.05.2015 07:25, Andrei Borzenkov wrote:
> В Fri, 29 May 2015 22:58:43 +0200
> Daniel Kiper <daniel.kiper@oracle.com> пишет:
>
>> Another questions is why grub_relocator_alloc_chunk_addr() does not consult EFI
>> memory map if grub_relocator_alloc_chunk_align() does. Should not we fix it?
>
> My best guess is that grub_relocator_alloc_chunk_addr() gets target
> from elsewhere so there is nothing to consult (it is caller
> responsibility); while grub_relocator_alloc_chunk_align() needs to
> actually search for suitable memory region.
>
My suggestion would be to pass avoid_boot_services = 1 in multiboot2 iff
we don't terminate the services. Any problems with this approach?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2015-07-15 17:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 17:59 [PATCH 0/5] multiboot2: Enable EFI boot services usage in loaded images Daniel Kiper
2015-01-30 17:59 ` [PATCH 1/5] multiboot2: Fix information request tag size calculation Daniel Kiper
2015-01-30 20:52 ` Ben Hildred
2015-01-30 21:21 ` Lennart Sorensen
2015-01-31 1:33 ` Ben Hildred
2015-02-14 16:27 ` Andrei Borzenkov
2015-01-30 17:59 ` [PATCH 2/5] i386/relocator: Remove unused extern grub_relocator64_rip_addr Daniel Kiper
2015-05-07 16:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-01-30 17:59 ` [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices argument Daniel Kiper
[not found] ` <554B8D05.4000004@gmail.com>
2015-05-29 20:58 ` Daniel Kiper
2015-05-30 5:25 ` Andrei Borzenkov
2015-07-15 17:50 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-07-16 12:02 ` Daniel Kiper
2015-01-30 17:59 ` [PATCH 4/5] i386/relocator: Add grub_relocator64_efi relocator Daniel Kiper
2015-01-30 17:59 ` [PATCH 5/5] multiboot2: Add tags used to pass ImageHandle to loaded image Daniel Kiper
2015-02-09 17:55 ` [PATCH 0/5] multiboot2: Enable EFI boot services usage in loaded images Daniel Kiper
2015-05-11 16:26 ` Is: grub2-mkconfig detecting ELF files the multiboot2 header and using proper module. Was:Re: " Konrad Rzeszutek Wilk
2015-05-11 16:38 ` Vladimir 'phcoder' Serbinenko
2015-05-11 18:56 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A69D7B.50702@gmail.com \
--to=phcoder@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=arvidjaar@gmail.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=grub-devel@gnu.org \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=keir@xen.org \
--cc=ning.sun@intel.com \
--cc=qiaowei.ren@intel.com \
--cc=richard.l.maliszewski@intel.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).