From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZN5TH-0003sn-Bm for mharc-grub-devel@gnu.org; Wed, 05 Aug 2015 16:39:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN5TF-0003ok-ED for grub-devel@gnu.org; Wed, 05 Aug 2015 16:39:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZN5TC-0005r9-32 for grub-devel@gnu.org; Wed, 05 Aug 2015 16:39:29 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:50823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZN5TB-0005qz-QT for grub-devel@gnu.org; Wed, 05 Aug 2015 16:39:26 -0400 Received: from pps.filterd (m0044008 [127.0.0.1]) by mx0a-00082601.pphosted.com (8.14.5/8.14.5) with SMTP id t75KaHkk028057; Wed, 5 Aug 2015 13:39:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=XC3SL53eB4NPMtKbDmlTbJOxuE/lri+dzAhFQ2ME0Jo=; b=aoaUvWO027OhjvzR46pOhwhVNbEVLdGXZCjCCngXwYbyC687BlNMKovSWM7jp4Dwlvqg BlGumgzFWpd98OP/owp3KFaJkXM/zde+Fy/xECyvKdBtVs3e32/i8cXZvJQU6zPtC7n1 t3HtInaD05ltD01WQktI9RN1NlwZyT/vxSI= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 1w3qcggeh7-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 05 Aug 2015 13:39:19 -0700 Received: from localhost.localdomain (192.168.52.123) by mail.thefacebook.com (192.168.16.24) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 5 Aug 2015 13:39:18 -0700 Message-ID: <55C27474.9010504@fb.com> Date: Wed, 5 Aug 2015 16:39:16 -0400 From: Josef Bacik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 1/3] efinet: handle get_status() properly References: <1438799799-32097-1-git-send-email-jbacik@fb.com> <20150805230442.1bf65b2d@opensuse.site> <55C27179.6020104@fb.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-08-05_10:2015-08-05, 2015-08-05, 1970-01-01 signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 67.231.145.42 Cc: Andrey Borzenkov , mchang@suse.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2015 20:39:30 -0000 On 08/05/2015 04:32 PM, Vladimir 'phcoder' Serbinenko wrote: > This patch improperly assumes that GRUB is the only thing in EFI that > transmits. Your patch surely fixed your machine but likely breaks some > other machines. Could you instead make an explicit check for (void *)1 > and add a comment on which machine it's necessary? > Yeah this is kind of a crap trade-off I know. The problem is this is just on one box I'm testing with, we've got _a metric shit ton_ of boxes, if one of them returns 0x2 suddenly it can't be provisioned. I realize this is racey with other things on UEFI doing stuff, but I don't have a better answer. Maybe a range check for obviously bogus addresses? Or maybe once we get a non-NULL from GetStatus() we call it again until we get a NULL from GetStatus()? Thanks, Josef