From: Josef Bacik <jbacik@fb.com>
To: Andrei Borzenkov <arvidjaar@gmail.com>,
The development of GNU GRUB <grub-devel@gnu.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH] efinet: retransmit if our device is busy
Date: Fri, 11 Sep 2015 15:08:29 -0400 [thread overview]
Message-ID: <55F326AD.1000509@fb.com> (raw)
In-Reply-To: <55F30604.90202@gmail.com>
On 09/11/2015 12:49 PM, Andrei Borzenkov wrote:
> 31.08.2015 20:34, Josef Bacik пишет:
>> When I fixed the txbuf handling I ripped out the retransmission code
>> since it
>> was flooding our network when we had the buggy behavior. Turns out
>> this was too
>> heavy handed as we can still have transient tx timeouts. So instead
>> make sure
>> we retry our transmission once per timeout. This way we can deal with
>> transient
>> transmission problems without flooding the box. This fixes an issue
>> we were
>> seeing in production. Thanks,
>>
>
> You mean you get timeout in efi send_card_buffer, not higher level? That
> sounds like something steals completion status. Could you send lsefi
> after network interface was opened?
No i get a timeout at a higher level. We try to transmit, we never get
the txbuf thing from getstatus, and we never redo the transmit. This
just adds the retransmit back in. Thanks,
Josef
prev parent reply other threads:[~2015-09-11 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 17:34 [PATCH] efinet: retransmit if our device is busy Josef Bacik
2015-09-11 16:49 ` Andrei Borzenkov
2015-09-11 19:08 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F326AD.1000509@fb.com \
--to=jbacik@fb.com \
--cc=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).