From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zkp2B-0005EV-Mv for mharc-grub-devel@gnu.org; Sat, 10 Oct 2015 03:57:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zki1Y-0001KY-At for grub-devel@gnu.org; Fri, 09 Oct 2015 20:28:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zki1S-0007s6-Rn for grub-devel@gnu.org; Fri, 09 Oct 2015 20:28:32 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:36926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zki1S-0007rd-JC for grub-devel@gnu.org; Fri, 09 Oct 2015 20:28:26 -0400 Received: by wicfx3 with SMTP id fx3so86047008wic.0 for ; Fri, 09 Oct 2015 17:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=b6hrZ96VpHJtlYuXyOuqkmDNK0MKA+QR3WrECQmwKiU=; b=tTboo7NtQ3nsnD4PiCvFDTo2da4VVPkwsPQvSj/KOvFSrg5o5SYszyKXzSsYZuSJVw gDqI/PVHqwKGzjAx8MKNrspqqBltOsy/AvEw7sXY91CEUVG9RO5ai3Z2ww9h6cvUEMG3 x5VDPCZTLhOsuqM+1dsW4EpNoFwltUn/7D8S9d0IBn05NgYdTSRLPi4y8QZRiM8G/um8 vaY4uTlyc5FYjZEPKUh1KaIT1c4HcdncGiuuuzix1OC89OtrhISl2hoS6smR8NFoXrt0 ldqXLl+OP82yXZoUPTVbCpO9+860yzYKFVaQ3wYxAWsUrOUT0HRwHkDPNJ8P64wuwE0w VbXw== X-Received: by 10.194.172.228 with SMTP id bf4mr8397419wjc.80.1444436905847; Fri, 09 Oct 2015 17:28:25 -0700 (PDT) Received: from [10.119.6.25] ([83.143.7.1]) by smtp.gmail.com with ESMTPSA id o10sm902720wia.4.2015.10.09.17.28.24 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 09 Oct 2015 17:28:24 -0700 (PDT) Subject: Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI. To: The development of GNU GRUB References: <1440009323-8667-1-git-send-email-mhw@netris.org> <55D6A36D.205@gmail.com> <876147ryhy.fsf@netris.org> <55D99791.4080104@gmail.com> <87a8thuqmo.fsf_-_@netris.org> <55EF16C0.6010703@gmail.com> <55F5186E.5040306@gmail.com> <56182E44.8010306@gmail.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <56185BA0.6030006@gmail.com> Date: Sat, 10 Oct 2015 02:28:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.2.0 MIME-Version: 1.0 In-Reply-To: <56182E44.8010306@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uVVr79c6owaRu8FsMo2KaKpNFBc6IeCxE" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Oct 2015 00:28:33 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uVVr79c6owaRu8FsMo2KaKpNFBc6IeCxE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09.10.2015 23:14, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > On 13.09.2015 08:32, Andrei Borzenkov wrote: >> 08.09.2015 20:11, Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >>> On 23.08.2015 23:50, Mark H Weaver wrote: >>>> Include -mabi=3D32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to comp= ile >>>> code for the O32 ABI when targetting MIPS, since the MIPS assembly c= ode >>>> in GRUB assumes this. >>> Could you be more precise where we assume this? Why not fix the assem= bly >>> instead? >> >> If I understand it correctly, this is not only about assembly - ABIs >> differ in sizes of types as well, > Only in obscure types long double and uint128_t. We use neither. Correction: I was comparing o32 to n32. We still need to ensure that either o32 or n32 is used. It's easier to just ensure that o32 is used, so that we have less variability in the code but can be relaxed later if need be. > f) int grub_setjmp (grub_jmp_buf env) // grub_jmp_buf is an array, so= > pointer > g) int grub_longjmp (grub_jmp_buf env, int val) Correction: setjmp/longjmp are not adapted to n32 but we don't use them anyway. Probably it's time to delete the dead code after double checking that extras don't use it either. --uVVr79c6owaRu8FsMo2KaKpNFBc6IeCxE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlYYW6AACgkQmBXlbbo5nOtEygEAiZ9uusrnfFZD/PjJppGe+lQ+ y4dmn0p1m8ThRgPZfRIA/jeQ0JFIaBitoR2t062gev4sz/6Qa4m8ZZaZbPr+jZb6 =EzvC -----END PGP SIGNATURE----- --uVVr79c6owaRu8FsMo2KaKpNFBc6IeCxE--