From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZmqcB-0006WI-Q1 for mharc-grub-devel@gnu.org; Thu, 15 Oct 2015 18:03:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmG0r-0007BM-Hj for grub-devel@gnu.org; Wed, 14 Oct 2015 02:58:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmG0o-0008PS-20 for grub-devel@gnu.org; Wed, 14 Oct 2015 02:58:13 -0400 Received: from mail-lb0-x22b.google.com ([2a00:1450:4010:c04::22b]:32950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmG0n-0008P5-Ql for grub-devel@gnu.org; Wed, 14 Oct 2015 02:58:09 -0400 Received: by lbbpp2 with SMTP id pp2so10080882lbb.0 for ; Tue, 13 Oct 2015 23:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Gaq23qssQCCHoja/fyZv/cgmgX9tR1YhQSfEgn07Uco=; b=CZfLZyhzhbPsdfOB+XBwQpPCSkO3iXHNP9hAo69w3q9xub1Ylvb9sSDSLU+qjnIHya GW19BduiC5xXNWiztO3y3f67oPyFFdw2zfT9ePfdoGwoJGRvb246DtoYRMxyl8y124ev E0jPRowMsA4G0mTKhR4u4Pu5KK7nAz7gTUkKA7RSLZrRdFU2w1SUMfEtLKuuzu2wExre GEM3UyYO6sJZqJcw7k794a6HV5+hRl9JwHCcH+oGcKwiDCi22GGrw7Y/7yYh6G08Fvq5 XKB2InDIu/IM/Buq+yGeCh5nAFSR4WI3BuoDmMQ7LgCFp3Zd1tEkiK3Ow9SbWGZ6injG FMjQ== X-Received: by 10.112.147.10 with SMTP id tg10mr707403lbb.58.1444805889057; Tue, 13 Oct 2015 23:58:09 -0700 (PDT) Received: from [192.168.1.43] (ppp91-76-142-206.pppoe.mtu-net.ru. [91.76.142.206]) by smtp.gmail.com with ESMTPSA id rs1sm1079774lbb.21.2015.10.13.23.58.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2015 23:58:07 -0700 (PDT) Subject: Re: [edk2] [grub PATCH] efinet: disable MNP background polling To: "Ye, Ting" , Laszlo Ersek , "daniel.kiper@oracle.com" , "grub-devel@gnu.org" References: <20151001.182655.371384337.d.hatayama@jp.fujitsu.com> <560D1E07.3090902@redhat.com> <20151013214919.GA6140@router-fw-old.local.net-space.pl> <561D83E9.6050703@redhat.com> <561DEED6.7050601@gmail.com> From: Andrei Borzenkov Message-ID: <561DFCFE.9080408@gmail.com> Date: Wed, 14 Oct 2015 09:58:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22b Cc: edk2-devel-01 , Mark Salter , "glin@suse.com" , "seth.goldberg@oracle.com" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 06:58:14 -0000 14.10.2015 09:15, Ye, Ting пишет: > May I know the details what problems it causes in some cases? > One is being discussed in this thread: http://lists.gnu.org/archive/html/grub-devel/2015-10/msg00013.html http://lists.gnu.org/archive/html/grub-devel/2015-10/msg00068.html Another was reported recently: http://lists.gnu.org/archive/html/help-grub/2015-09/msg00033.html http://lists.gnu.org/archive/html/grub-devel/2015-10/msg00071.html > Thanks, > Ye Ting > > -----Original Message----- > From: Andrei Borzenkov [mailto:arvidjaar@gmail.com] > Sent: Wednesday, October 14, 2015 1:58 PM > To: Ye, Ting; Laszlo Ersek; daniel.kiper@oracle.com; grub-devel@gnu.org > Cc: konrad.wilk@oracle.com; edk2-devel-01; glin@suse.com; seth.goldberg@oracle.com; Mark Salter > Subject: Re: [edk2] [grub PATCH] efinet: disable MNP background polling > > 14.10.2015 08:19, Ye, Ting пишет: >> Hi all, >> >> If I understand the issue correctly, I don't quite agree that UEFI spec is imprecise about SNP constraints described as following. >> The "constraint" described here is that the grub should use attribute "EXCLUSIVE" to open SNP protocol to gain exclusive access. This usage is clearly described in page 184, chapter 6.3 EFI_BOOT_SERVICES.OpenProtocol(). >> >> EXCLUSIVE Used by applications to gain exclusive access to a protocol interface. >> If any drivers have the protocol interface opened with an attribute of BY_DRIVER, >> then an attempt will be made to remove them by calling the driver's Stop() function. >> >> The grub code should not assume that the SNP is not occupied by other drivers, instead, it should use EXCLUSIVE to open SNP protocol, or to be more precise, use OpenProtocolInformation() to check whether SNP is already opened by other driver, then decide whether need to use EXCLUSIVE to disconnect the other drivers. This is the typical usage for all UEFI protocol, not particular constraints to SNP protocol. >> > > That is exactly what grub currently does - it opens SNP exclusively. > Apparently it is causing problems in some cases. >