Re: flex version

Re: flex version

[Andrei Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

14.11.2015 19:22, Peter Cheung пишет:
> hi
>     my flex in mac is installed using macports.
>
> $flex --version
> flex 2.5.35 Apple(flex-31)
>
> And the line in configure fail
>
> version=`$LEX --version | $AWK '{ split($NF,x,"."); print x[1]*10000+x[2]*100+x[3]; }’`
>
> Better to change it to:
>
> version=`$LEX --version | sed 's/flex //'|sed 's/ .*//'| $AWK '{ split($NF,x,"."); print x[1]*10000+x[2]*100+x[3]; }’`
>

Does attached patch help?

[-- Attachment #2: awk-macports.patch --]
[-- Type: text/x-patch, Size: 992 bytes --]

From: Andrei Borzenkov <arvidjaar@gmail.com>
Subject: [PATCH] configure: fix macports flex version detection

Macports add extra information after version itself:

$flex --version
flex 2.5.35 Apple(flex-31)

We require at least felx 2.5.35 so do not need to care about prehistoric
"flex version n.n.n"; just use second field always.

Reported by Peter Cheung <mcheung63@hotmail.com>

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 9e8a606..3300545 100644
--- a/configure.ac
+++ b/configure.ac
@@ -315,7 +315,7 @@ AC_PROG_LN_S
 if test "x$LEX" = "x:"; then
   AC_MSG_ERROR([flex is not found])
 else
-  version=`$LEX --version | $AWK '{ split($NF,x,"."); print x[[1]]*10000+x[[2]]*100+x[[3]]; }'`
+  version=`$LEX --version | $AWK '{ split($2,x,"."); print x[[1]]*10000+x[[2]]*100+x[[3]]; }'`
   if test -n "$version" -a "$version" -ge 20535; then
     :
   else
-- 
tg: (7994077..) u/flex-macports (depends on: master)

RE: flex version

[Peter Cheung]

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

Thanks, it works


> Subject: Re: flex version
> To: mcheung63@hotmail.com; grub-devel@gnu.org; help-grub@gnu.org
> From: arvidjaar@gmail.com
> Date: Sun, 15 Nov 2015 09:26:11 +0300
> 
> 14.11.2015 19:22, Peter Cheung пишет:
> > hi
> >     my flex in mac is installed using macports.
> >
> > $flex --version
> > flex 2.5.35 Apple(flex-31)
> >
> > And the line in configure fail
> >
> > version=`$LEX --version | $AWK '{ split($NF,x,"."); print x[1]*10000+x[2]*100+x[3]; }’`
> >
> > Better to change it to:
> >
> > version=`$LEX --version | sed 's/flex //'|sed 's/ .*//'| $AWK '{ split($NF,x,"."); print x[1]*10000+x[2]*100+x[3]; }’`
> >
> 
> Does attached patch help?
 		 	   		  

[-- Attachment #2: Type: text/html, Size: 1113 bytes --]

RE: flex version

[Peter Cheung]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

One side question, only mac need this patch. If we do it this way:
flex --version | egrep -o '[0-9]+\.[0-9]+\.[0-9]+'
Then linux flex also works fine.
thanksfrom Peter
> Subject: Re: flex version
> To: mcheung63@hotmail.com; grub-devel@gnu.org; help-grub@gnu.org
> From: arvidjaar@gmail.com
> Date: Sun, 15 Nov 2015 09:26:11 +0300
> 
> 14.11.2015 19:22, Peter Cheung пишет:
> > hi
> >     my flex in mac is installed using macports.
> >
> > $flex --version
> > flex 2.5.35 Apple(flex-31)
> >
> > And the line in configure fail
> >
> > version=`$LEX --version | $AWK '{ split($NF,x,"."); print x[1]*10000+x[2]*100+x[3]; }’`
> >
> > Better to change it to:
> >
> > version=`$LEX --version | sed 's/flex //'|sed 's/ .*//'| $AWK '{ split($NF,x,"."); print x[1]*10000+x[2]*100+x[3]; }’`
> >
> 
> Does attached patch help?
 		 	   		  

[-- Attachment #2: Type: text/html, Size: 1743 bytes --]

Re: flex version

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

Andrei, could you please commit this patch?
On 15.11.2015 07:26, Andrei Borzenkov wrote:
> 14.11.2015 19:22, Peter Cheung пишет:
>> hi
>>     my flex in mac is installed using macports.
>>
>> $flex --version
>> flex 2.5.35 Apple(flex-31)
>>
>> And the line in configure fail
>>
>> version=`$LEX --version | $AWK '{ split($NF,x,"."); print
>> x[1]*10000+x[2]*100+x[3]; }’`
>>
>> Better to change it to:
>>
>> version=`$LEX --version | sed 's/flex //'|sed 's/ .*//'| $AWK '{
>> split($NF,x,"."); print x[1]*10000+x[2]*100+x[3]; }’`
>>
> 
> Does attached patch help?
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]