From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: grub causing NVDIMMs to be treated as normal memory
Date: Fri, 27 Nov 2015 14:55:43 +0100 [thread overview]
Message-ID: <565860DF.8090709@gmail.com> (raw)
In-Reply-To: <CAA91j0WG3-m1Zmw1n-BrX8POfwkR4KDWewchLJA4-W6BVos7Bw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1699 bytes --]
New version attached
>> GRUB_MEMORY_COREBOOT_TABLES = 16,
>> GRUB_MEMORY_CODE = 20,
>> /* This one is special: it's used internally but is never reported
>>>>> Note (b): The internal GRUB_MEMORY_CODE (20) value is
>>>>> leaking through to the E820 table.
>>>>>
>>>>> That appears to be from this patch on 2013-10-14:
>>>>> 6de9ee86 Pass-through unknown E820 types
>>>>
>>>> If we are discussing ACPI 6.0 systems here, it explicitly says that
>>>> values above 12 should be treated as reserved. Does it cause
>>>> problems?
>>>
>>> All undefined values are reserved for future standardization;
>>> the meaning they might have in the future is unpredictable.
>>>
>>> Software compatible with ACPI 6.0 is supposed to treat them as
>>> reserved, but software compatible with a future version of ACPI
>>> might interpret them as having some different meaning that isn't
>>> compatible with GRUB_MEMORY_CODE.
>>>
>>> Some companies used e820 type 12 to mean persistent memory without
>>> getting that assigned by the ACPI WG, so that value was
>>> contaminated. We should probably mark 20 as contaminated too,
>>> given this issue.
>>>
>> I see now that we have leaked 16 (coreboot tables) as well. Could we
>> mark 16 as contaminated as well?
>> For memory code: should we just pass reserved in linux e820 or is it
>> better to keep doing this bug given possible reliance on it by other
>> software?
>
> I think it is better to leave it as is as long as those values can be reserved.
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #1.2: pram.diff --]
[-- Type: application/x-patch, Size: 1643 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2015-11-27 13:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 23:52 grub causing NVDIMMs to be treated as normal memory Elliott, Robert (Persistent Memory)
2015-11-25 14:08 ` Andrei Borzenkov
2015-11-25 16:51 ` Dan Williams
2015-11-25 17:04 ` Elliott, Robert (Persistent Memory)
2015-11-25 17:07 ` Seth Goldberg
2015-11-25 18:36 ` Andrei Borzenkov
2015-11-26 0:12 ` Elliott, Robert (Persistent Memory)
2015-11-26 3:30 ` Andrei Borzenkov
2015-11-26 6:15 ` Elliott, Robert (Persistent Memory)
2015-11-26 16:55 ` Andrei Borzenkov
2015-11-26 23:24 ` Elliott, Robert (Persistent Memory)
2015-11-27 3:58 ` Andrei Borzenkov
2015-11-27 6:22 ` Elliott, Robert (Persistent Memory)
2015-11-27 11:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-27 11:48 ` Andrei Borzenkov
2015-11-27 13:55 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-11-27 17:23 ` Andrei Borzenkov
2015-11-28 6:41 ` Elliott, Robert (Persistent Memory)
2015-12-01 0:25 ` Elliott, Robert (Persistent Memory)
2015-12-03 17:50 ` Elliott, Robert (Persistent Memory)
2015-12-08 17:15 ` Andrei Borzenkov
2015-12-09 6:37 ` Elliott, Robert (Persistent Memory)
2015-12-29 17:17 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565860DF.8090709@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).