From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1a4ufE-0006tn-8G for mharc-grub-devel@gnu.org; Fri, 04 Dec 2015 13:01:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4ufB-0006tb-Dt for grub-devel@gnu.org; Fri, 04 Dec 2015 13:00:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4ufA-0002R5-Fy for grub-devel@gnu.org; Fri, 04 Dec 2015 13:00:57 -0500 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:36664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4ufA-0002Qv-2o for grub-devel@gnu.org; Fri, 04 Dec 2015 13:00:56 -0500 Received: by wmww144 with SMTP id w144so71844619wmw.1 for ; Fri, 04 Dec 2015 10:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=oFNEFFn7ZpRY/Fp+UmnaO/m4mngvf+GtpG6U3JuIZsg=; b=jtG32o+7sZdT5VoLVe4e68Mn7jC1n32nTsUmp39q7zshcwJ3/RQHiwd6WLVXOwZI5R hRfskjlSI2xfW2ru7Z9oyPV2eAGAGAOXE1XAilKRo8OqDcZt3Fhj+z80Nnne60I3dD2a bt2LAI0Hs/afE1my2csMLPhuMfMKl82K+qtB59HKAiaqAKR87NVokP32RoS5YLsCVEKf T9HpsrWlwQCJfB3W0rgCRVZ49dq+oyRUIBBg9piVHTkc4YSSZKKgdqiQ3Y/4HLpWFm1n WU5GuKaH4ZumR08NmtGUc1Yt/55R4UIUQFddPA5VcL8Y29jl3H/JMXXTh0iRrmFzhIo3 o6ig== X-Received: by 10.194.216.234 with SMTP id ot10mr18650878wjc.44.1449252055005; Fri, 04 Dec 2015 10:00:55 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:a2a8:cdff:fe64:b3b5? ([2620:0:105f:fd00:a2a8:cdff:fe64:b3b5]) by smtp.gmail.com with ESMTPSA id l128sm4448469wmf.10.2015.12.04.10.00.53 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Dec 2015 10:00:53 -0800 (PST) Subject: Re: [PATCH 1/3] mkstandalone: add argument --fixed-time to override mtime of files To: grub-devel@gnu.org References: <1449245444-17579-1-git-send-email-lynxis@fe80.eu> <1449245444-17579-2-git-send-email-lynxis@fe80.eu> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= X-Enigmail-Draft-Status: N1110 Message-ID: <5661D4CD.30204@gmail.com> Date: Fri, 4 Dec 2015 19:00:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <1449245444-17579-2-git-send-email-lynxis@fe80.eu> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ukM94eoSDFcWbauBUew16FHIO71AgAXuQ" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::235 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 18:00:58 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ukM94eoSDFcWbauBUew16FHIO71AgAXuQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04.12.2015 17:10, Alexander Couzens wrote: > mkstandalone adds several files to an archive. Doing this it uses the > mtime to give these files a timestamp. > --fixed-time overrides these timestamps with a given. >=20 > Replacing all timestamps with a specific one is required > to get reproducible builds. See source epoch specification of > reproducible-builds.org Patch in general looks good. I'm unsure about which way the timestamp should be passed and parsed. I see 3 solutions: 1) Argument and use some standard function to parse date supply argument + 2) Essentially what you have done. It feels a bit ugly but not too much 3) Read directly from variable. WDYT? > + {"fixed-time", 't', N_("TIMEEPOCH"), 0, N_("Use a fixed timestamp to= override mtime of all files. Time since epoch is used."), 2}, It's not worth spending a letter on this. Please keep only long version. --ukM94eoSDFcWbauBUew16FHIO71AgAXuQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlZh1NUACgkQmBXlbbo5nOuMZwD/aF5eeCnDHpK8sUHQcetaPzT+ 8ha0Uyw1EUQsGue/9bgBAJwLZ20K+lphQQ/9b+Wv5wdIIw5OKP1MB7fuAyluTpxd =II7u -----END PGP SIGNATURE----- --ukM94eoSDFcWbauBUew16FHIO71AgAXuQ--