Re: [PATCH 1/3] mkstandalone: add argument --fixed-time to override mtime of files

[Andrei Borzenkov <arvidjaar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

04.12.2015 21:00, Vladimir 'φ-coder/phcoder' Serbinenko пишет:
> On 04.12.2015 17:10, Alexander Couzens wrote:
>> mkstandalone adds several files to an archive. Doing this it uses the
>> mtime to give these files a timestamp.
>> --fixed-time <TIME_EPOCH> overrides these timestamps with a given.
>>
>> Replacing all timestamps with a specific one is required
>> to get reproducible builds. See source epoch specification of
>> reproducible-builds.org
> Patch in general looks good. I'm unsure about which way the timestamp
> should be passed and parsed. I see 3 solutions:
> 1) Argument and use some standard function to parse date supply argument
> +<value>

As long as it is user-facing option, more human oriented timestamp
parsing would be nice. One option would be strptime() with some
predefined formats or may be even getdate() which allows user to define
own input formats.

> 2) Essentially what you have done. It feels a bit ugly but not too much
> 3) Read directly from variable.
> WDYT?
>> +  {"fixed-time", 't', N_("TIMEEPOCH"), 0, N_("Use a fixed timestamp to override mtime of all files. Time since epoch is used."), 2},
> It's not worth spending a letter on this. Please keep only long version.
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]