From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1a56R9-0007S5-96 for mharc-grub-devel@gnu.org; Sat, 05 Dec 2015 01:35:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a56R7-0007Rx-Ep for grub-devel@gnu.org; Sat, 05 Dec 2015 01:35:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a56R4-0001qv-9I for grub-devel@gnu.org; Sat, 05 Dec 2015 01:35:13 -0500 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:36472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a56R4-0001qk-1g for grub-devel@gnu.org; Sat, 05 Dec 2015 01:35:10 -0500 Received: by lfs39 with SMTP id 39so121644510lfs.3 for ; Fri, 04 Dec 2015 22:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=fZ8+oLQlZBgDDPK5GqibFEL8RLOnIdCqsBTEH+HwQrs=; b=XovOhO2g0GZeTz71yiIHB0uPmyoZyOqFYLoVuByg896cqjmvLqAflYcGoYkIBlOZ9U 4sjemGAxeb3sz3WHkQ9HBBv7pKw/nwBncItIEln+UIFz1MiKH8r9InElMBcdO4JavgiK ZmMUIvcYF2qtoylFuuwo5pDSu623ntxTuXLkA+A8nwuLKSSCPS3FnjPa5NL0mXvVznzD dKs49LxkJBPNdUYEOWmtR2uoOigrJvyKUu7ShwfHXqPvOkCM/jCYTL5ho7A1+CfCccqc FeQhgDIj0lWmUZY1D9WvPfLCvwHXwd5MzjndMlc9TZjlETwXPCIaPmYSQDJ3+pC4Y7R+ 7s/w== X-Received: by 10.25.209.148 with SMTP id i142mr9935410lfg.163.1449297309330; Fri, 04 Dec 2015 22:35:09 -0800 (PST) Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru. [91.76.25.247]) by smtp.gmail.com with ESMTPSA id m5sm2898202lfe.22.2015.12.04.22.35.08 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Dec 2015 22:35:08 -0800 (PST) Subject: Re: [PATCH 1/3] mkstandalone: add argument --fixed-time to override mtime of files To: grub-devel@gnu.org References: <1449245444-17579-1-git-send-email-lynxis@fe80.eu> <1449245444-17579-2-git-send-email-lynxis@fe80.eu> <5661D4CD.30204@gmail.com> From: Andrei Borzenkov X-Enigmail-Draft-Status: N1110 Message-ID: <56628597.6050404@gmail.com> Date: Sat, 5 Dec 2015 09:35:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5661D4CD.30204@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XJNgSST8fROOHx8E1JIQH8WnXMEj0U3B8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2015 06:35:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XJNgSST8fROOHx8E1JIQH8WnXMEj0U3B8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 04.12.2015 21:00, Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 04.12.2015 17:10, Alexander Couzens wrote: >> mkstandalone adds several files to an archive. Doing this it uses the >> mtime to give these files a timestamp. >> --fixed-time overrides these timestamps with a given. >> >> Replacing all timestamps with a specific one is required >> to get reproducible builds. See source epoch specification of >> reproducible-builds.org > Patch in general looks good. I'm unsure about which way the timestamp > should be passed and parsed. I see 3 solutions: > 1) Argument and use some standard function to parse date supply argumen= t > + As long as it is user-facing option, more human oriented timestamp parsing would be nice. One option would be strptime() with some predefined formats or may be even getdate() which allows user to define own input formats. > 2) Essentially what you have done. It feels a bit ugly but not too much= > 3) Read directly from variable. > WDYT? >> + {"fixed-time", 't', N_("TIMEEPOCH"), 0, N_("Use a fixed timestamp t= o override mtime of all files. Time since epoch is used."), 2}, > It's not worth spending a letter on this. Please keep only long version= =2E >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --XJNgSST8fROOHx8E1JIQH8WnXMEj0U3B8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlZihZwACgkQR6LMutpd94xBsQCdEHRRWNM7IqdVot9QmawY6KRd dZYAnj0eS3E5eO++HsdKmVkGPT87Q8kZ =6iIo -----END PGP SIGNATURE----- --XJNgSST8fROOHx8E1JIQH8WnXMEj0U3B8--