From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aDEjW-0006TQ-V9 for mharc-grub-devel@gnu.org; Sun, 27 Dec 2015 12:03:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDEjT-0006SF-Um for grub-devel@gnu.org; Sun, 27 Dec 2015 12:03:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDEjP-0002WF-U2 for grub-devel@gnu.org; Sun, 27 Dec 2015 12:03:47 -0500 Received: from mail-lf0-x235.google.com ([2a00:1450:4010:c07::235]:32943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDEjP-0002WB-MM for grub-devel@gnu.org; Sun, 27 Dec 2015 12:03:43 -0500 Received: by mail-lf0-x235.google.com with SMTP id p203so191120199lfa.0 for ; Sun, 27 Dec 2015 09:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=VTUUz0YtOxoC3qLsewIP/bltLLLrvI2x0mxSHrZUgQg=; b=cHsSI2k1hKxJQjouAVApRtR/hiXMp+PNBsO7MoQnsNNJ4pW7dS7VPLVQU+LYp92TZr VGsuAVY2KY3BSMyPij5PznTZ7Cq3ULErNv1GK9X2WzshWA0HsCKLYvneQA5/o5HSdvtQ AZvfpI7DZIMoveBKpV8979rGwLBcfoXbHCNAbL3r0tIy0elGkPGTuV+eWMKfrvIpPBk6 6eS09seBLl1/gMsXKVCvw3rKXdqdsAjP0JK1p7sFQ8pkqOFlpFvNJYItuSv4MxZEtgMT 7udU3mftj1W2Yj4nx2Ea7nchOEI41l07Nh5HxdsLKlM8ow3OhUUB0Rb3K9u97j1sX4BG IrZA== X-Received: by 10.25.26.68 with SMTP id a65mr8634932lfa.24.1451235822843; Sun, 27 Dec 2015 09:03:42 -0800 (PST) Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru. [91.76.25.247]) by smtp.gmail.com with ESMTPSA id eb3sm4222857lbc.31.2015.12.27.09.03.41 for (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 Dec 2015 09:03:41 -0800 (PST) Subject: Re: [PATCH] Allow to add/change menu entry class defaults. To: grub-devel@gnu.org References: <567969EB.1090109@riseup.net> <567B0A0A.2050804@riseup.net> <567F03CE.9050007@riseup.net> From: Andrei Borzenkov X-Enigmail-Draft-Status: N1110 Message-ID: <568019E8.2040301@gmail.com> Date: Sun, 27 Dec 2015 20:03:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <567F03CE.9050007@riseup.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VjiTK8MkJNjpxu1ugLceTqebrWirxuv8M" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::235 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Dec 2015 17:03:49 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VjiTK8MkJNjpxu1ugLceTqebrWirxuv8M Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 27.12.2015 00:17, Robin Schneider =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > I am sorry for the misunderstanding. I should have explained the indent= ion > behind my patch a bit better then just linking to another patch which m= akes use > of the newly introduced variables by this patch. >=20 > My indented use case is to allow to add options like '--unrestricted' o= r > '--users "Jane"' to each menuentry generated by grub-mkconfig without a= ltering > the scripts itself. Oh, no, sorry. CLASS is for adding --class option and --class option is for defining icon used to represent menu entry. Please do not misuse it for something else. I try to understand possible use cases. Please get a look at https://lists.gnu.org/archive/html/grub-devel/2015-05/msg00170.html thread. SUSE has actually implemented my suggestion. This gives us "all menu entries unrestricted" case. Do you really have situation where you need separate category of users that won't have access to CLI but will be the *only* users allowed to select non-default menu entry? Moreover, do you really need to allow different users to boot different categories of menu entries? =2E.. >=20 > BTW: The efi menuentry has the class 'windows'. Is that correct? My pat= ch > assumes that this menuentry is indented for UEFI applications. >=20 Well, so far upstream os-prober only detects Windows on EFI. But yes, SUSE includes additional script. See https://lists.gnu.org/archive/html/grub-devel/2015-12/msg00103.html - does it address your concern? --VjiTK8MkJNjpxu1ugLceTqebrWirxuv8M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlaAGewACgkQR6LMutpd94z7jwCfdSfAWun6JSKxdzU92NMEqmiC DL4An2PRJAf/sAF8l/PnuYSRl7wbZjSS =9v2W -----END PGP SIGNATURE----- --VjiTK8MkJNjpxu1ugLceTqebrWirxuv8M--