From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aHDaA-0005Ha-Fb for mharc-grub-devel@gnu.org; Thu, 07 Jan 2016 11:38:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDa4-0005Ai-RN for grub-devel@gnu.org; Thu, 07 Jan 2016 11:38:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDa3-0004no-NA for grub-devel@gnu.org; Thu, 07 Jan 2016 11:38:32 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:36670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDa3-0004ni-Gi for grub-devel@gnu.org; Thu, 07 Jan 2016 11:38:31 -0500 Received: by mail-wm0-x232.google.com with SMTP id l65so104177533wmf.1 for ; Thu, 07 Jan 2016 08:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=5KtlHhezeORHRzzSeM0DYSDkcNiEjmsEtRp3IZPHoRA=; b=NahO2CKY/XQHMOdIR2ESRKqfrzkD4hcI0tmivC1s5HFMttU5sT3sEHkBI3kvOqzxET SkbPHjvW+B+AXRwM1+0l5HhISmv2q/2CJTTad9BdOdI5t51bZ/8r3EWF9tfyO30DvAMP jBUysVvTyQHZznG2x5y5T3rJUOejbdV1zLWAtZqlcFc60w75SuA2GRjTZws9ytHVA3X7 HlfqYf8DJ66qeO/C2p2ZMY/zIex8qmhoYAsq//968QqDWsGG1m+0sI1A7Nc+myXjEamj 82eWjEGwsXtqFWjKYMURydjEZnAerLmCz0LTDw2A4VvfzLjvs5E8Za22sPK8V7n03twr oTWA== X-Received: by 10.28.221.215 with SMTP id u206mr18519385wmg.58.1452184710662; Thu, 07 Jan 2016 08:38:30 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:a2a8:cdff:fe64:b3b5? ([2620:0:105f:fd00:a2a8:cdff:fe64:b3b5]) by smtp.gmail.com with ESMTPSA id ka4sm2135137wjc.47.2016.01.07.08.38.29 for (version=TLSv1/SSLv3 cipher=OTHER); Thu, 07 Jan 2016 08:38:29 -0800 (PST) Subject: Re: enable_progress_indicator To: The development of GNU GRUB References: <568CFA18.1030109@gmail.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <568E947D.4040203@gmail.com> Date: Thu, 7 Jan 2016 17:38:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <568CFA18.1030109@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="evBmGTJDUUNSsdOaj9q8qc5RAxEOEhf6v" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::232 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2016 16:38:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --evBmGTJDUUNSsdOaj9q8qc5RAxEOEhf6v Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06.01.2016 12:27, Andrei Borzenkov wrote: > Do we really need yet another magic variable? Tests already set > "grubshell", and in normal case why would one load progress but then > disable it? >=20 > Why progress gets loaded in the first place? Can we somehow omit it? >=20 emu loads all the modules. And we use emu to generate checksums.h. So unless we disable progress on it, all of our golden images will have it which would be bad. Before this variable there was no way of disabling progress once module is loaded (I wouldn't recommend unloading any modules currently). So it's probably good to have some way of disabling it when need be independently of tests. We may also want to have tests specifically for progress (we'll have to mock out the timer for this), so it doesn't seem like grubshell is the right variable to check. > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --evBmGTJDUUNSsdOaj9q8qc5RAxEOEhf6v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlaOlIQACgkQmBXlbbo5nOtzaQD+MAzrrtWfHedEvb6EqxUXRPgy ESyp524g5T/wzpofeucA/A8dGiWjIfrB0O1T6M21VErpJnes8jIeFUa7eC0V/eDV =wAfH -----END PGP SIGNATURE----- --evBmGTJDUUNSsdOaj9q8qc5RAxEOEhf6v--