* ARM*-EFI timers @ 2016-01-07 18:08 Vladimir 'φ-coder/phcoder' Serbinenko 2016-01-07 18:59 ` Andrei Borzenkov 0 siblings, 1 reply; 3+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2016-01-07 18:08 UTC (permalink / raw) To: The development of GRUB 2 [-- Attachment #1.1: Type: text/plain, Size: 375 bytes --] Hello, all. In my automated tests I found out that on ARM64-EFI sleep 10 actually sleeps for 100s. The culprit is that EFI doesn't call our timer every 1ms but every 10ms. I propose time1.diff to correct: request EFI to call us every 10ms and increment timer variable by 10. For arm64 I propose to use CPU timer instead time2.diff. Can any of ARM guys comment on this? [-- Attachment #1.2: time1.diff --] [-- Type: application/x-ext-patch, Size: 747 bytes --] [-- Attachment #1.3: time2.diff --] [-- Type: application/x-ext-patch, Size: 2208 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 213 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ARM*-EFI timers 2016-01-07 18:08 ARM*-EFI timers Vladimir 'φ-coder/phcoder' Serbinenko @ 2016-01-07 18:59 ` Andrei Borzenkov 2016-01-07 19:55 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 1 reply; 3+ messages in thread From: Andrei Borzenkov @ 2016-01-07 18:59 UTC (permalink / raw) To: grub-devel [-- Attachment #1: Type: text/plain, Size: 886 bytes --] 07.01.2016 21:08, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > Hello, all. In my automated tests I found out that on ARM64-EFI sleep 10 > actually sleeps for 100s. The culprit is that EFI doesn't call our timer > every 1ms but every 10ms. I propose time1.diff to correct: request EFI > to call us every 10ms and increment timer variable by 10. openSUSE carries similar patch for quite some time. Patch is authored by RH. So it can be considered tested in real life. https://build.opensuse.org/package/view_file/Base:System/grub2/grub2-arm64-Reduce-timer-event-frequency-by-10.patch?expand=1 > For arm64 I propose to use CPU timer instead time2.diff. Can any of ARM > guys comment on this? > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ARM*-EFI timers 2016-01-07 18:59 ` Andrei Borzenkov @ 2016-01-07 19:55 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 0 replies; 3+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2016-01-07 19:55 UTC (permalink / raw) To: The development of GNU GRUB [-- Attachment #1: Type: text/plain, Size: 1190 bytes --] On 07.01.2016 19:59, Andrei Borzenkov wrote: > 07.01.2016 21:08, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >> Hello, all. In my automated tests I found out that on ARM64-EFI sleep 10 >> actually sleeps for 100s. The culprit is that EFI doesn't call our timer >> every 1ms but every 10ms. I propose time1.diff to correct: request EFI >> to call us every 10ms and increment timer variable by 10. > > openSUSE carries similar patch for quite some time. Patch is authored by > RH. So it can be considered tested in real life. > > https://build.opensuse.org/package/view_file/Base:System/grub2/grub2-arm64-Reduce-timer-event-frequency-by-10.patch?expand=1 > Ok, I took RH patch. Now question is about the second patch >> For arm64 I propose to use CPU timer instead time2.diff. Can any of ARM >> guys comment on this? >> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> > > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 213 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-07 19:55 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-07 18:08 ARM*-EFI timers Vladimir 'φ-coder/phcoder' Serbinenko 2016-01-07 18:59 ` Andrei Borzenkov 2016-01-07 19:55 ` Vladimir 'φ-coder/phcoder' Serbinenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).