From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aPQ2D-0003ug-23 for mharc-grub-devel@gnu.org; Sat, 30 Jan 2016 02:33:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPQ2A-0003uK-5V for grub-devel@gnu.org; Sat, 30 Jan 2016 02:33:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPQ26-0006TW-Ve for grub-devel@gnu.org; Sat, 30 Jan 2016 02:33:26 -0500 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:35326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPQ26-0006TQ-NE for grub-devel@gnu.org; Sat, 30 Jan 2016 02:33:22 -0500 Received: by mail-lf0-x22e.google.com with SMTP id l143so2814315lfe.2 for ; Fri, 29 Jan 2016 23:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=dgrzy0L19Hvn/vidv+BTIigauWJWjD3OVfaQSYShIhc=; b=YxHxTY1cA0uwKVhDCFV5pUhcaJDnTi0CozhplEmnk0jEOZIJdSwfc5vDKLblwAsHvf GmiPugyCvfOCpGtKtxCmperTLvSaodlw41hoqdxw7T5iiMV0yhWtMxp9n23iNR4bgs3M sbsipHQJ4sVZeTFiHf5HB7eHIGhn9wR+kjKbcR6Md0FFq7FlONCAefmRDTPAWtPD4i7R umzDG2YnzVNUvDOta2oIOo/nuiwXpbUopCfwJf05iY6RLaFAF9cQ+/AVZUdisUP5o+11 ayLJIiiQ2jnzPPnHgrLALYy5cCTUabrYb+FN4iYb/ESvKgJGCY2+QTn46xaq1JzKYnhn 68OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=dgrzy0L19Hvn/vidv+BTIigauWJWjD3OVfaQSYShIhc=; b=CvaSJiwgHeNBj5EP5TsmCICt6ZV0TgAIpQCdlc9Ck/jT8VZnjgdKwPxDXtLtE5U/7T MvT1Gt8VcAz05TGyYPlcgPHMexn/jXvp2AuV+RUo8jODZHbvtcD3E1vV0PpI2sf5E0Hf oHiMVwvuedeRnKsvUFhPq1DqSlYDHT6rsyPQnHsJE/1P6DkuJk9z8W0yMUy7LfL1Wvwn jAGPQSfJNSj6Kjd+XnSuN+pVGbuF7th5pBCKv7Vc/mV+u7NYJvBIZ2AePoLF8D69vnG+ QvNbrKS2flZ18rl0Iz+DsDlIaAMnHOZFbZCPQ/VA5poZ1FHGCkbbyyIZaoaQqRKTF82P 2XjQ== X-Gm-Message-State: AG10YOSrdM9OYvgBDomXonCLawLrW2SEHlnJrzC0ty9lZi72W5KDBRh0KzLrtJsfXtZ5oA== X-Received: by 10.25.207.65 with SMTP id f62mr3870244lfg.73.1454139201878; Fri, 29 Jan 2016 23:33:21 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id p138sm2525936lfb.22.2016.01.29.23.33.20 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Jan 2016 23:33:20 -0800 (PST) Subject: Re: [PATCH] menu_entry: Disable cursor during update_screen() To: The development of GNU GRUB References: <1454077618-18986-1-git-send-email-thuth@redhat.com> From: Andrei Borzenkov Message-ID: <56AC6740.6090008@gmail.com> Date: Sat, 30 Jan 2016 10:33:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454077618-18986-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2016 07:33:27 -0000 29.01.2016 17:26, Thomas Huth пишет: > When running grub in a VGA console of a KVM pseries guest on PowerPC, > you can see the cursor sweeping over the whole line when entering a > character in editor mode. This is visible because grub always refreshes > the whole line when entering a character in editor mode, and drawing > characters is quite a slow operation with the firmware used for the > powerpc pseries guests (SLOF). > To avoid this ugliness, the cursor should be disabled when refreshing > the screen contents during update_screen(). > While it looks OK - any reason it is not present in Fedora grub2 GIT? > Signed-off-by: Thomas Huth > --- > grub-core/normal/menu_entry.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/grub-core/normal/menu_entry.c b/grub-core/normal/menu_entry.c > index 62c7e16..68359eb 100644 > --- a/grub-core/normal/menu_entry.c > +++ b/grub-core/normal/menu_entry.c > @@ -250,6 +250,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen, > mode = ALL_LINES; > } > > + grub_term_setcursor (term_screen->term, 0); > + > if (mode != NO_LINE) > { > /* Draw lines. This code is tricky, because this must calculate logical > @@ -357,6 +359,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen, > > } > > + grub_term_setcursor (term_screen->term, 1); > + > grub_term_refresh (term_screen->term); > } > >