From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aTqWK-0003xa-5a for mharc-grub-devel@gnu.org; Thu, 11 Feb 2016 07:38:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTqWH-0003uC-Dw for grub-devel@gnu.org; Thu, 11 Feb 2016 07:38:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTqWF-0002pG-QC for grub-devel@gnu.org; Thu, 11 Feb 2016 07:38:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:60177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTqWF-0002pC-Jh for grub-devel@gnu.org; Thu, 11 Feb 2016 07:38:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EA6FDABB1; Thu, 11 Feb 2016 12:38:46 +0000 (UTC) Subject: Re: [PATCH v2 2/6] xen: factor out allocation of special pages into separate function To: Daniel Kiper References: <1455177206-8974-1-git-send-email-jgross@suse.com> <1455177206-8974-3-git-send-email-jgross@suse.com> <20160211122143.GB3482@olila.local.net-space.pl> From: Juergen Gross Message-ID: <56BC80D6.40909@suse.com> Date: Thu, 11 Feb 2016 13:38:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160211122143.GB3482@olila.local.net-space.pl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 Cc: grub-devel@gnu.org, phcoder@gmail.com, mchang@suse.com, xen-devel@lists.xen.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 12:38:50 -0000 On 11/02/16 13:21, Daniel Kiper wrote: > On Thu, Feb 11, 2016 at 08:53:22AM +0100, Juergen Gross wrote: >> Do the allocation of special pages (start info, console and xenbus >> ring buffers) in a separate function. This will allow to do the >> allocation at different times of the boot preparations depending on >> the features the kernel is supporting. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/loader/i386/xen.c | 50 +++++++++++++++++++++++++++++---------------- >> 1 file changed, 32 insertions(+), 18 deletions(-) >> >> diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c >> index 42ed7c7..e48cc3f 100644 >> --- a/grub-core/loader/i386/xen.c >> +++ b/grub-core/loader/i386/xen.c >> @@ -54,6 +54,8 @@ static grub_uint64_t modules_target_start; >> static grub_size_t n_modules; >> static struct grub_relocator_xen_state state; >> static grub_xen_mfn_t *virt_mfn_list; >> +static struct start_info *virt_start_info; >> +static grub_xen_mfn_t console_pfn; > > Same as in patch #1. Same answer. :-) Juergen