From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aVGJg-0006dX-LP for mharc-grub-devel@gnu.org; Mon, 15 Feb 2016 05:23:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVGJe-0006c6-8l for grub-devel@gnu.org; Mon, 15 Feb 2016 05:23:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVGJZ-0003Ed-6W for grub-devel@gnu.org; Mon, 15 Feb 2016 05:23:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVGJZ-0003EX-15 for grub-devel@gnu.org; Mon, 15 Feb 2016 05:23:33 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3A96EC0C2348; Mon, 15 Feb 2016 10:23:32 +0000 (UTC) Received: from [10.36.4.209] (vpn1-4-209.ams2.redhat.com [10.36.4.209]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1FANR2r014830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 Feb 2016 05:23:30 -0500 Subject: Re: [PATCH] menu_entry: Disable cursor during update_screen() To: Andrei Borzenkov , The development of GNU GRUB References: <1454077618-18986-1-git-send-email-thuth@redhat.com> <56AC6740.6090008@gmail.com> <56AE2210.20008@redhat.com> <56BEDE3C.5010408@gmail.com> From: Thomas Huth X-Enigmail-Draft-Status: N1110 Message-ID: <56C1A71F.60608@redhat.com> Date: Mon, 15 Feb 2016 11:23:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56BEDE3C.5010408@gmail.com> Content-Type: text/plain; charset=utf-8 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 10:23:39 -0000 Hi Andrei, On 13.02.2016 08:41, Andrei Borzenkov wrote: > 31.01.2016 18:02, Thomas Huth =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> On 30.01.2016 08:33, Andrei Borzenkov wrote: >>> 29.01.2016 17:26, Thomas Huth =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> When running grub in a VGA console of a KVM pseries guest on PowerPC= , >>>> you can see the cursor sweeping over the whole line when entering a >>>> character in editor mode. This is visible because grub always refres= hes >>>> the whole line when entering a character in editor mode, and drawing >>>> characters is quite a slow operation with the firmware used for the >>>> powerpc pseries guests (SLOF). >>>> To avoid this ugliness, the cursor should be disabled when refreshin= g >>>> the screen contents during update_screen(). >>> >>> While it looks OK - any reason it is not present in Fedora grub2 GIT? >> >> Sorry, I didn't quite got your question ... do you mean the problem ca= n >> not be seen with the version from Fedora? If so, how did you start QEM= U >> to run the guest? >=20 > I usually expect that patches from distributions initially appear in > distribution packages, so I was surprised that I could not see it in > Fedora package. Ah, ok, simple answer: Although I'm working for Red Hat, I am not involved in the Fedora project (yet). And the problem with the cursor during update_screen() has been found while testing RHEL, not Fedora, so discussing this issue directly upstream here seems to make more sense for me (and if the patch is fine for you and it gets included, Fedora will automatically benefit from this, too, once they update to a new version of grub). Regards, Thomas