From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aW5SZ-0001Sz-Us for mharc-grub-devel@gnu.org; Wed, 17 Feb 2016 12:00:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW5SX-0001Ou-A4 for grub-devel@gnu.org; Wed, 17 Feb 2016 12:00:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW5SS-0006ig-B0 for grub-devel@gnu.org; Wed, 17 Feb 2016 12:00:13 -0500 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:36840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW5SS-0006iM-2C for grub-devel@gnu.org; Wed, 17 Feb 2016 12:00:08 -0500 Received: by mail-lb0-x22d.google.com with SMTP id x1so13177749lbj.3 for ; Wed, 17 Feb 2016 09:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=AjgohufXuEEEzBZtYMdMF7xJbPzKde4zr+oYaY19dhw=; b=QZnwouUPSySo4h9Wy9NwOt/VhS16QmdBkjIlZZG+Y8b/R2SezFaMMKoSm0uoDZMdwB u8DHMoScsKMji43QUD3M7TSV9X4Huu/mbMQM4ZX2Bbwc/y0dH1XP6UnIg4XMWG1G9Cu6 CJkVpeE5uLm2Ncxlc3Mml4UZGAUl4A9hGM5Kn0td8U3zqYdSSbGaJzMzbE+ZbJc9CH4R 65Ln4nA29lHtcxqH4ZjRGLbYNhuI/7iuLSSzT7j1RURwYoHtTCFosdqCHH0eExypbg27 M+d9U4C285kUQR5StB9ALnHv7m/0IhX7ILSLLhaSxL2lG0U0IYP3UYw+P4Aaqa5yuRdp c5aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=AjgohufXuEEEzBZtYMdMF7xJbPzKde4zr+oYaY19dhw=; b=Wu1AYpUzVaqYEX4Wx1jnDCoiyAr3VE5yGxn68NY9NS2Xk7Gp/XtstbyiXt0JLuqkWv kgGGPz0x8vEyakd0NiW7q3mGodDxbpNpAyhIpkQ1T0xM7y13W3JdFM6JAidX1vo2wBRF Sd5chbxLdzNO/dpRbaEvGhQGu9G085rfZWMfORPAheUxYEqVGhppm29ZOPcPtclc7xjC rodSrtNr/d63Y7V4Sd2Q6hgBfnS3yqAMNWnwf2GL1EA5AAwXZiZJPtEMuhi+Puu8/L/j aJ84fCyfmQhjmOv/AkIrosnvuS5FyKaoHkOc7NkDx+4pgwAGG7OwS230eu8RaSpHXhHu cFRQ== X-Gm-Message-State: AG10YOTFLwtHeBLy2+Oeov57yg+2UGlLaLLTyemLlqtXMbvCq7vrAesy31vdvhDzRa4+mA== X-Received: by 10.112.173.164 with SMTP id bl4mr1093259lbc.144.1455728407180; Wed, 17 Feb 2016 09:00:07 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id tv1sm328965lbb.4.2016.02.17.09.00.05 for (version=TLSv1/SSLv3 cipher=OTHER); Wed, 17 Feb 2016 09:00:06 -0800 (PST) Subject: Re: Respect EFI block-io buffer alignment To: grub-devel@gnu.org References: <20160217154825.GD1159@bivouac.eciton.net> <56C49E90.3070307@gmail.com> From: Andrei Borzenkov Message-ID: <56C4A712.4090909@gmail.com> Date: Wed, 17 Feb 2016 20:00:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56C49E90.3070307@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wSoVuvfgSer4sFLgrncCRBmFgL0tKtEjD" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2016 17:00:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wSoVuvfgSer4sFLgrncCRBmFgL0tKtEjD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 17.02.2016 19:23, Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 17.02.2016 16:48, Leif Lindholm wrote: >> This resolves a complete failure to access devices connected to the >> SATA port on the ARM ltd. Juno platform (apart from a violation of the= >> UEFI block io protocol). >> >> The below is a bit of a hack, but I'd like some feedback on preferred >> solution before over(or under)engineering something. >> >> As far as I can tell, a struct_disk is only ever allocated in >> kern/disk.c, using grub_zalloc(). So the only reason for the horrid >> ifdefs is that there is no grub_memalign for EMU. >> >> Do I: >> - Keep the ifdefs? >> - Implement grub_memalign() for EMU? > You could insipire by grub_osdep_dl_memalign >> - Something else? >> > The code as-is will not work. Buf is passed from external call to > grub_disk_read and grub_disk_read tries to read in-place whenever > possible. There are 2 cases in current codebase when we need a special It can be changed to read into cache and copy in buf instead of read into buf and copy in cache. --wSoVuvfgSer4sFLgrncCRBmFgL0tKtEjD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlbEpxUACgkQR6LMutpd94y9iACgoHnqZ7bnsVYVGtOZHjkYopjG Xi4AoIPB7KUSWz0/EkchNLW3A8KnQY3L =FcEB -----END PGP SIGNATURE----- --wSoVuvfgSer4sFLgrncCRBmFgL0tKtEjD--