From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aXkTb-00071d-Pw for mharc-grub-devel@gnu.org; Mon, 22 Feb 2016 02:00:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXkTZ-0006zR-Em for grub-devel@gnu.org; Mon, 22 Feb 2016 02:00:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXkTW-0003BO-8W for grub-devel@gnu.org; Mon, 22 Feb 2016 02:00:09 -0500 Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:34604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXkTW-00039n-1I for grub-devel@gnu.org; Mon, 22 Feb 2016 02:00:06 -0500 Received: by mail-lf0-x22a.google.com with SMTP id j78so87505566lfb.1 for ; Sun, 21 Feb 2016 23:00:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=uONrcSlf6EEEHavcZYD25Du1xb2/WFL2wkIaoAtV1x8=; b=uPl70qGhUnDXFazR10ogpulAMUt282LvfQQFSzazCuhys4pTzJBRD5z7E7qEz95RU5 fsiF2KnHAaYQa6oPX5xo5kCNtGTdWCFPk8ncS6A1N3ArIyKq8bpwqnf8BWPgLESOcS7R QRKoo8PdZ+V35UB2yOi8Zi6B9PMhF9oIQM2C7nkD+YCMyOD+r/CGAz4XhJnW/+57vmCl v3WPDZPyPuI2FUCX07wUirYRJqoqlxpbaYeaJOSbG/w2XLss4e5mRRssC/PT0oM9Sm5P e1qXepyccN2Paji4xBwV1GVpnBbBVqqVyTRULUQ34oHXRD0bL1C/1lbyXF8sYU2O7iRR BOiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=uONrcSlf6EEEHavcZYD25Du1xb2/WFL2wkIaoAtV1x8=; b=HKvjq/dZyz9N2IoaGu/6BUpTvGKvSPHBm2/xs0MBLdYG2z0AI3PfEX6f/6iSIlgkug S0zqm+gh0UjorIOfu3Z73jNNtqFO9kat27ML/rta+PbHkEZn04H5J0+ftPoLAHeb4gdY ZGHAEyO6Gm4ZGwmuv9Rz+9QTHne4TcaWJ0O4gIOkOEbURpwf4dBR0wth6JFzDJfghH+t 75t3MD7sTwfwJmgOGBA2JuzI/X9cyfgOI7Y0dHmGj5OwosC422P4yuQfgC0XEUUG38ep aljP4vVRUmajBzHVaQ1lGf15ul8p7CXNvEj9D6pdL7WxXscea5vl0ErNgDSWYxFABbZi ofGg== X-Gm-Message-State: AG10YOSvrgOm6z01Avry2Lq/VsGGD/loLMUj16xze021FHkNlhU2KH475LSdMrISt1rJMw== X-Received: by 10.25.153.12 with SMTP id b12mr9724761lfe.117.1456124404787; Sun, 21 Feb 2016 23:00:04 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id nv8sm3059853lbb.7.2016.02.21.23.00.03 for (version=TLSv1/SSLv3 cipher=OTHER); Sun, 21 Feb 2016 23:00:03 -0800 (PST) Subject: Re: [PATCH] menu_entry: Disable cursor during update_screen() To: grub-devel@gnu.org References: <1454077618-18986-1-git-send-email-thuth@redhat.com> From: Andrei Borzenkov Message-ID: <56CAB1F2.8090005@gmail.com> Date: Mon, 22 Feb 2016 10:00:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454077618-18986-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2016 07:00:10 -0000 29.01.2016 17:26, Thomas Huth пишет: > When running grub in a VGA console of a KVM pseries guest on PowerPC, > you can see the cursor sweeping over the whole line when entering a > character in editor mode. This is visible because grub always refreshes > the whole line when entering a character in editor mode, and drawing > characters is quite a slow operation with the firmware used for the > powerpc pseries guests (SLOF). > To avoid this ugliness, the cursor should be disabled when refreshing > the screen contents during update_screen(). > Applied, thanks! > Signed-off-by: Thomas Huth > --- > grub-core/normal/menu_entry.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/grub-core/normal/menu_entry.c b/grub-core/normal/menu_entry.c > index 62c7e16..68359eb 100644 > --- a/grub-core/normal/menu_entry.c > +++ b/grub-core/normal/menu_entry.c > @@ -250,6 +250,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen, > mode = ALL_LINES; > } > > + grub_term_setcursor (term_screen->term, 0); > + > if (mode != NO_LINE) > { > /* Draw lines. This code is tricky, because this must calculate logical > @@ -357,6 +359,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen, > > } > > + grub_term_setcursor (term_screen->term, 1); > + > grub_term_refresh (term_screen->term); > } > >