* OBP available region patch fails with clang
@ 2016-02-24 17:35 Andrei Borzenkov
2016-02-24 19:13 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Borzenkov @ 2016-02-24 17:35 UTC (permalink / raw)
To: The development of GNU GRUB, Eric Snowberg; +Cc: daniel.kiper@oracle.com
kern/ieee1275/mmap.c:52:22: error: comparison of integers of different
signs: 'grub_ssize_t'
(aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
if (available_size > sizeof (available))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
1 error generated.
While we can of course cast to (grub_ssize_t) sizeof (available) -
should not we check for available_size < 0 as well?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: OBP available region patch fails with clang 2016-02-24 17:35 OBP available region patch fails with clang Andrei Borzenkov @ 2016-02-24 19:13 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 0 replies; 2+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2016-02-24 19:13 UTC (permalink / raw) To: The development of GNU GRUB [-- Attachment #1: Type: text/plain, Size: 667 bytes --] On 24.02.2016 18:35, Andrei Borzenkov wrote: > kern/ieee1275/mmap.c:52:22: error: comparison of integers of different > signs: 'grub_ssize_t' > (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare] > if (available_size > sizeof (available)) > ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~ > 1 error generated. > > While we can of course cast to (grub_ssize_t) sizeof (available) - > should not we check for available_size < 0 as well? > I have fixed it locally but forgot to push > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 213 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-24 19:13 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-24 17:35 OBP available region patch fails with clang Andrei Borzenkov 2016-02-24 19:13 ` Vladimir 'φ-coder/phcoder' Serbinenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).