From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aYejg-0006Tb-UZ for mharc-grub-devel@gnu.org; Wed, 24 Feb 2016 14:04:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYeja-0006OF-NT for grub-devel@gnu.org; Wed, 24 Feb 2016 14:04:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYejV-0003Qy-Nu for grub-devel@gnu.org; Wed, 24 Feb 2016 14:04:26 -0500 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:35396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYejV-0003Qo-Fp for grub-devel@gnu.org; Wed, 24 Feb 2016 14:04:21 -0500 Received: by mail-lb0-x22a.google.com with SMTP id bc4so16028222lbc.2 for ; Wed, 24 Feb 2016 11:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=WJsMGj3tc+Dn8/JLS0c4y6MXtFicaYOyjFbYYadoTKM=; b=nUDdyuxuxAD1IxBb/7h1NsU9f0bJTQcL+Dxk08oguw3LTD+LElm+qFIAjKUf3QjnzE i/dOnvRHhBsiQbCRHegOMxMD51rxL7/QpDIJjXcgEz6/mEjwIyURtmQ0GEVOyYSQh9xR 4KdTwgjqfWZUUs+0HnMoXEnBbDAonkcx3NQGtQqt8RA/m9iDzkmhSW+ac5W7GBUITtvr nUNoxovxhfERQ5u3ZW6cqehQ7NyVLmuedGz/4AtyP0wvnsN60HWcC2gPimlwzTV0aYoT GDgwM5KCbxmBtm6UaicMWKHfxDZqWocFJKLUayAxsycQDuFDmcVgcT5BbG6xpw81clj7 6KaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=WJsMGj3tc+Dn8/JLS0c4y6MXtFicaYOyjFbYYadoTKM=; b=f9v5/9a1pFMD2a1aIMJlXFb6zhBb2l7/8AftqfKFtmAYPNkvn2333ScWuJjVSQ/T0X LCUANRD15Ch7HPRr6sapwQBasR3Cn1A/LBY1wZOiV+ngs5iOhGtCD64KaaA6nzhKtXYJ RpV9tZhQ7NwIAa0GDM9ore/oxV5XwuQATxq7OvNCdI8jsWyMDIu2RoNnI4Rpn4Ggtb5x WPBIEElRhRTjG1VZ9HC4C0C+ZrmPgLNedUEuc/lAjNLcmy9htFfCG0sYpkjOlyBfq3Lh NkXrxvBOGicfBeMC7kS9i4dbUyviWY/TNvYOejviREY7vegcKI9EXqVvApFD27UPQMGn 5dwA== X-Gm-Message-State: AG10YOScKSXFeSg9/vqMD5y/Y/yEKW6TQV0OS4kXeV4wafW1zTIttXGYt7uvfs/Z6f4dug== X-Received: by 10.112.173.71 with SMTP id bi7mr15106246lbc.93.1456340660631; Wed, 24 Feb 2016 11:04:20 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id jb5sm572985lbc.8.2016.02.24.11.04.18 for (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Feb 2016 11:04:19 -0800 (PST) Subject: Re: [PATCH 1/2] disk: Add support for device-specific malloc function To: grub-devel@gnu.org References: <1455898714-25127-1-git-send-email-leif.lindholm@linaro.org> <1455898714-25127-2-git-send-email-leif.lindholm@linaro.org> <56CABF64.7020003@gmail.com> <20160222140255.GO1159@bivouac.eciton.net> <56CB3DB9.4050102@gmail.com> <20160224115921.GU1159@bivouac.eciton.net> <20160224135738.GV1159@bivouac.eciton.net> <56CDEB27.6060606@gmail.com> From: Andrei Borzenkov Message-ID: <56CDFEB2.5010104@gmail.com> Date: Wed, 24 Feb 2016 22:04:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56CDEB27.6060606@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 19:04:31 -0000 24.02.2016 20:40, Andrei Borzenkov пишет: > 24.02.2016 16:57, Leif Lindholm пишет: >> On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote: >>>>> Could you test attached patch with your alignment fixes on top. This >>>>> implements my idea of using shared buffers. Seems to work in naive testing. >>>> >>>> Testing this with a grub-mkstandalone image, I get: >>>> >>>> kern/dl.c:556: flushing 0x10f1 bytes at 0x9ffb5ac20 >>>> kern/dl.c:649: module name: tar >>>> kern/dl.c:650: init function: 0x9ffb5b220 >>>> kern/disk.c:217: Opening `memdisk'... >>>> kern/fs.c:56: Detecting tarfs... >>>> >>>> And then spectacular crash in UEFI due to an EL2 translation fault. >>> >>> To be sure - is it with my patch alone or with your patches? If some >>> more patches are used - could you send exact diff to trunk to avoid >>> misunderstanding? >> >> Double checked with only your patch on top of >> 1b782e902e69516f82158203674d4951a40c82d4 (previously running with >> _only_ my alignment fixup in efidisk.c). Same behaviour. > > I cannot reproduce it on x86_64 (also with mm-debug enabled) and I do > not know how to load standalone image on ppc; is it possible to use QEMU > to run ARM64 (I assume you have it)? If not what are options to test it? > > Anyway, there was one problem I fixed later (although I did not get any > issue before as well), I attach updated version. Thank you for testing! > I still cannot reproduce it with either patch version using current GIT QEMU + binary QEMU_EFI.fd from http://snapshots.linaro.org/components/kernel/leg-virt-tianocore-edk2-upstream/554/QEMU-AARCH64/RELEASE_GCC49/QEMU_EFI.fd; I run it as aarch64-softmmu/qemu-system-aarch64 -m 1024 -cpu cortex-a57 -M virt -bios ~/vm/QEMU_EFI.fd -cdrom /tmp/grub.iso -serial stdio Where grub.iso is built pkgdatadir=$PWD ./grub-mkstandalone -d grub-core -O arm64-efi -o /tmp/grub.efi pkgdatadir=$PWD ./grub-mkrescue -d grub-core -o /tmp/grub.iso /grub.efi=/tmp/grub.efi and I do chainloader /grub.efi boot after that.