From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aYesm-00010R-KY for mharc-grub-devel@gnu.org; Wed, 24 Feb 2016 14:13:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYesj-0000zF-Ml for grub-devel@gnu.org; Wed, 24 Feb 2016 14:13:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYesi-0006RR-PF for grub-devel@gnu.org; Wed, 24 Feb 2016 14:13:53 -0500 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:37008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYesi-0006RL-H9 for grub-devel@gnu.org; Wed, 24 Feb 2016 14:13:52 -0500 Received: by mail-wm0-x236.google.com with SMTP id g62so44381176wme.0 for ; Wed, 24 Feb 2016 11:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=NJFnq6ADc1Dt2SJbD67iTdBw0DCwU431aLy2ww6OzFk=; b=G3cjF6KGmzXHsEdnZjFIBipm2+/twC3OK6gMvFCMImolE9oLPX6mS+7JShgAJSiHAM fJDCqcYxWD29LPYWwhFihxQyAehyhHrxMe9b9cXR7Hvuo988Ug+Yug24Ho6t7GXSZZZ2 EGwn+sx5Rf1bGhO2aTqMJUraVOTWn1g3HQLZOU2s+AUd+cywxMc883LLXmK8IeAC5zQ7 z7yA4Piki3rhYumlM4uGnDgx54ylXwfD8MuSHBmRUBjuh+8T5+sJzlLpmprlISCeFuvD izIQyIykAtziXYTzLg/Xzk4p4WdQPO7YciElToWKhIbjmfWHDaeisvJvMbj0llkp3HTW VIdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=NJFnq6ADc1Dt2SJbD67iTdBw0DCwU431aLy2ww6OzFk=; b=STfj7FuxzDAHB9f5zacSjgS1N5U7V5fenRUfOTMbosy5OK9gL2DBT+WuKePGjCM5eB EmJkjdo28D9bRQTcLz5iYADU0tA//Af8B7YaBgFW0/FMmCKBr4+bcMoGWfRbckhSFbyg nANKlebeN69aDRpXL4l5SMZfk9nWU6+7gIiGkI9Li7yU6hbXM0XhWKJphIxu0tFpwZ+l THuVFylIOyCddC3weguKzm3TXT3Er1Ro30hq8PYlPb4b3Wf7djvMIXSWdJPAbQO/wwmT Gujgx5ScPkEpng0xYQN6/SjhTeBfJ5G3d7WOyMY963LBsPjVBT1Y1P+9220SwUN2G8d+ DLyQ== X-Gm-Message-State: AG10YOQGvwX1Qd1t+46xSgOQhpZJIo3IbvjXquvVXma0hRBjcfgB43KRDLTYYpNd3MRtMQ== X-Received: by 10.28.96.198 with SMTP id u189mr27693958wmb.55.1456341231975; Wed, 24 Feb 2016 11:13:51 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:a2a8:cdff:fe64:b3b5? ([2620:0:105f:fd00:a2a8:cdff:fe64:b3b5]) by smtp.gmail.com with ESMTPSA id j10sm4339852wjb.46.2016.02.24.11.13.51 for (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Feb 2016 11:13:51 -0800 (PST) Subject: Re: OBP available region patch fails with clang To: The development of GNU GRUB References: <56CDE9E5.5060408@gmail.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <56CE00EE.8080600@gmail.com> Date: Wed, 24 Feb 2016 20:13:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <56CDE9E5.5060408@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="coAfxPdUKXTFjDUcf0vHFFdF6aM6Jc5ro" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::236 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 19:13:54 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --coAfxPdUKXTFjDUcf0vHFFdF6aM6Jc5ro Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24.02.2016 18:35, Andrei Borzenkov wrote: > kern/ieee1275/mmap.c:52:22: error: comparison of integers of different > signs: 'grub_ssize_t' > (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare] > if (available_size > sizeof (available)) > ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~ > 1 error generated. >=20 > While we can of course cast to (grub_ssize_t) sizeof (available) - > should not we check for available_size < 0 as well? >=20 I have fixed it locally but forgot to push >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --coAfxPdUKXTFjDUcf0vHFFdF6aM6Jc5ro Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlbOAO4ACgkQmBXlbbo5nOueygD/UVMBIVuJiBWpfwub3vkr01Wg D9Univ0JUM6Sga25d/cBAKKDRTJQHioa3PqtZqIFcfiJeaA21HIMEbF8tu5AkmtM =AuS5 -----END PGP SIGNATURE----- --coAfxPdUKXTFjDUcf0vHFFdF6aM6Jc5ro--