From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aYzs2-0001xJ-ST for mharc-grub-devel@gnu.org; Thu, 25 Feb 2016 12:38:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYzrz-0001tR-9i for grub-devel@gnu.org; Thu, 25 Feb 2016 12:38:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYzrw-0001Ls-4T for grub-devel@gnu.org; Thu, 25 Feb 2016 12:38:31 -0500 Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:33589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYzrv-0001Ln-SF for grub-devel@gnu.org; Thu, 25 Feb 2016 12:38:28 -0500 Received: by mail-lf0-x229.google.com with SMTP id m1so38062056lfg.0 for ; Thu, 25 Feb 2016 09:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=0w8lKCocHfzMpkZaErbDjdUL7OtyIln/LmhnUM2yKM4=; b=z5bAaNiOeGMibFuZOHTCHJGDqgwxCpk/NbZL5GCRfHCmEmp61dImU0cS8Mo6WQayRW +CrmGL67IP3q53mwgDDp5y+pk2noaHtZa1OJKpWX8M9bvVNbXWBe5YaGLTBO76wE2Ptt g/fr8YK9k4zJnseFgquwuhqdmQL+KarL6/KETut4lOWAtO/XCNCl7crpjjSw5sI4++qA DLKUQ9UX8aZEeLP/7YydR2VhCVHl4tyQnOZeoVrk9qMq4uAri3JMfwhh2MNNk9ggTcr1 k4BdOra1di/ZCzYGULRIGc8HSq5hDmX5mUTFrr4xi7fZGqAw+sn+Y9XCBXCI/wy5Ta/K 6jUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=0w8lKCocHfzMpkZaErbDjdUL7OtyIln/LmhnUM2yKM4=; b=IMBXOIe7h8fV1uTsgm6Qz+GGIpPqNe/kzBxJJh3h76rmnqQ/E4cNago8wt7dJb4LdA ikGE04rBa1iEAp0DC8OEOouTOgY5p2jt8/mYxiAX86IfH8pyv9pIf+TZiP2JSP6HcVwV 0x8fPFDfB2yHr7Ju7tJiePQui41M5R1dnQSJo/6CuuUfjdlvYUM8UQUwnxrdGKaYXnZz 5jzv+K5T87qekLMGuBfW71ne9OdbdZZr4eDv8hvkOpLpt1SNzb+aPKxF9mrgJ27wm2bB g8FbEnefmZu95DH77zArOmgVyR7C4/BOmAs4sfv2EJjCt9kLwsevzk3eprmo1pMQXQZK 4Qrg== X-Gm-Message-State: AG10YOTXWPBy6x8IpYVCcENS4zmOWc2lgSLk76Srx8gEGPp2CSVvYnGZUirLTbtAbyoZig== X-Received: by 10.25.151.149 with SMTP id z143mr14793435lfd.72.1456421906954; Thu, 25 Feb 2016 09:38:26 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id i66sm1297771lfg.4.2016.02.25.09.38.25 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 25 Feb 2016 09:38:26 -0800 (PST) Subject: Re: [PATCH v4 02/11] xen: avoid memleaks on error To: The development of GNU GRUB , Juergen Gross References: <1456120999-5639-1-git-send-email-jgross@suse.com> <1456120999-5639-3-git-send-email-jgross@suse.com> <20160222082432.GM3482@olila.local.net-space.pl> From: Andrei Borzenkov Message-ID: <56CF3C10.40005@gmail.com> Date: Thu, 25 Feb 2016 20:38:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160222082432.GM3482@olila.local.net-space.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::229 Cc: phcoder@gmail.com, mchang@suse.com, xen-devel@lists.xen.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2016 17:38:32 -0000 22.02.2016 11:24, Daniel Kiper пишет: > > Are you sure that grub_errno is always set to GRUB_ERR_NONE > if any GRUB2 function finished successfully? grub_errno is reset by command parser before command execution (or after previous command finished actually). During command execution there is no guarantee that this happens; sometimes grub_errno is explicitly reset to suppress subsequent errors but in general errors are just passed through. > Maybe you should > set initialize grub_errno with GRUB_ERR_NONE at the beginning > of parse_xen_guest()? > > Daniel > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >