[PATCH] coreboot: fix "make default_payload.elf"

[PATCH] coreboot: fix "make default_payload.elf"

[Antonello Dettori]

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

When building grub as a payload for coreboot the compiling stops at this 
line:
"rm: cannot remove 'default_payload.elf': No such file or directory" 
(Full log <http://pastebin.com/vwjycq82>)
It seems like it's trying to delete default_payload.elf before it is 
even created without any apparent reason or explanation.

Tested, "make default_payload.elf" now works and the final executable 
works as expected.

Signed-off-by: Antonello Dettori <dev@dettori.io>

---

  Makefile.am | 1 -
  1 file changed, 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 288e621..82154d8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -410,7 +410,6 @@ bootcheck: $(BOOTCHECKS)

  if COND_i386_coreboot
  default_payload.elf: grub-mkstandalone grub-mkimage FORCE
-    rm $@
      pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O 
i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard 
usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' 
--install-modules='ls linux search configfile normal cbtime cbls memrw 
iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci 
lsacpi chain test serial multiboot cbmemc linux16 gzio echo help 
syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 
$(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ 
/boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
  endif

[-- Attachment #2: Type: text/html, Size: 1857 bytes --]

Re: [PATCH] coreboot: fix "make default_payload.elf"

[Vladimir 'phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]

Reason for this RM is to avoid stale for in case of failure. I fixed RM
invocation

Le ven. 26 févr. 2016 01:46, Antonello Dettori <dev@dettori.io> a écrit :

> When building grub as a payload for coreboot the compiling stops at this
> line:
> "rm: cannot remove 'default_payload.elf': No such file or directory" (Full
> log <http://pastebin.com/vwjycq82>)
> It seems like it's trying to delete default_payload.elf before it is even
> created without any apparent reason or explanation.
>
> Tested, "make default_payload.elf" now works and the final executable
> works as expected.
>
> Signed-off-by: Antonello Dettori <dev@dettori.io> <dev@dettori.io>
>
> ---
>
>  Makefile.am | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 288e621..82154d8 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -410,7 +410,6 @@ bootcheck: $(BOOTCHECKS)
>
>  if COND_i386_coreboot
>  default_payload.elf: grub-mkstandalone grub-mkimage FORCE
> -    rm $@
>      pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O
> i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms
> part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs'
> --install-modules='ls linux search configfile normal cbtime cbls memrw iorw
> minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain
> test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell
> cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts=
> --themes= --locales= -d grub-core/
> /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
>  endif
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #2: Type: text/html, Size: 2552 bytes --]