From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aZJ02-0005qy-Hf for mharc-grub-devel@gnu.org; Fri, 26 Feb 2016 09:04:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZIzz-0005mH-Qw for grub-devel@gnu.org; Fri, 26 Feb 2016 09:04:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZIzt-0000vV-VD for grub-devel@gnu.org; Fri, 26 Feb 2016 09:04:03 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:36763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZIzt-0000v8-LJ for grub-devel@gnu.org; Fri, 26 Feb 2016 09:03:57 -0500 Received: by mail-wm0-x241.google.com with SMTP id a4so9220907wme.3 for ; Fri, 26 Feb 2016 06:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=aLNNPAFnS9G4hpwDO+RUOf348b4qSmiYQAn994I5WcA=; b=DtG3e8KoySpqg5GesXhCYGtTzlUWJ1ARtZvpHPm150kW45hV31g7P7WTBhYVTDnfAO NSdz6RQ9qDrjTLDQPX/JKgV8Hogm1LA7434ouCKn65SUYLdw+iC6nCJkUdPRs5SrvUZ+ MaFdbK12txK4TM39Rx8/VCqJaSBpIKHPJN7QhXBloIrhJg6XHLdX8wRWm6ABXP+u6w1Q 8zFnvBKM0XKyXtgbi/l1GgE/7Ty+gbCBh/gvMBKj0dL2Soroy/BwiePVhzYvYZNNj+hy N8ok8qjNb9/EEchz/5vaCxcHk4/Ra8LyxLmFzsXxcL/PdVKL/RF9zfoDH1iUT6OO+zEg 26oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=aLNNPAFnS9G4hpwDO+RUOf348b4qSmiYQAn994I5WcA=; b=iUROSma+IDL99zRPjAVOS0gHR9S9pBmrnO/m/FhHMosWVc9/g/gI26mD1I/8kC6GWS S1CNmSpaCaC3+5mxEP0XqcDSf9+e5S7zHTYGdVaA8fGaryWYxibxdHAX0bqGuL0b/RHN F2drkjPYliOF25Gc1FYLOXzVsglyOl68r9R1vHys+TbKytzykqsD0exgCciyvSi804M8 ZvLJx4U2iwmSfs48ENbXhT+7M+5HjQohnxkywvciLr+kf6/LdYD7wFkNYq605/6boxiT jAZlOYWObg7hCEmIG67kAL19bkDWJlBE6z+EsfHEUUZomrXFvesVTz8ZTTnRzL3VnC8t yC7w== X-Gm-Message-State: AD7BkJJ6PX54ig2CxpPFzzLcT2buHYx3cSZKHLwHT1pu1k0ocULx9nZfKN72d4wcGVIWgQ== X-Received: by 10.194.71.135 with SMTP id v7mr1867694wju.135.1456495436945; Fri, 26 Feb 2016 06:03:56 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:a2a8:cdff:fe64:b3b5? ([2620:0:105f:fd00:a2a8:cdff:fe64:b3b5]) by smtp.gmail.com with ESMTPSA id p125sm3039938wmd.16.2016.02.26.06.03.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Feb 2016 06:03:55 -0800 (PST) Subject: Re: [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi To: Fu Wei , Andrei Borzenkov References: <1456382355-24614-2-git-send-email-fu.wei@linaro.org> <1456382355-24614-5-git-send-email-fu.wei@linaro.org> <56CF3B24.6030605@gmail.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <56D05B45.2050001@gmail.com> Date: Fri, 26 Feb 2016 15:03:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::241 Cc: The development of GNU GRUB , "xen-devel@lists.xensource.com" , Ian Campbell , Jon Masters , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 14:04:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26.02.2016 12:15, Fu Wei wrote: > Hi Andrei, >=20 > On 26 February 2016 at 18:50, Andrei Borzenkov wr= ote: >> On Fri, Feb 26, 2016 at 8:59 AM, Fu Wei wrote: >>>>>>> +@subsection xen_module >>>>>>> >>>>>>> -@deffn Command xen_linux file [arguments] >>>>>>> -Load a dom0 kernel image for xen hypervisor at the booting proce= ss of xen. >>>>>>> +@deffn Command xen_module [--nounzip] file [arguments] >>>>>>> +Load a module for xen hypervisor at the booting process of xen. >>>>>>> The rest of the line is passed verbatim as the module command lin= e. >>>>>>> +Each module will be identified by the order in which the modules= are added. >>>>>>> +The 1st module: dom0 kernel image >>>>>>> +The 2nd module: dom0 ramdisk >>>>>>> +All subsequent modules: UNKNOW >>>>>>> @end deffn >>>>>> >>>>>> Hmm ... from previous discussion I gathered that Xen can detect mo= dule >>>>>> type. What if there is no initrd for dom0? How can subsequent modu= les be >>>>> >>>>> Now , Xen detect module type by the order. (at least on ARM64). >>>>> I think i386 is using Multiboot(2) protocol, so maybe this order is= >>>>> nothing to do with i386. >>>>> >>>> >>>> Then we have obvious problem with your XSM patch (http://savannah.gn= u.org/bugs/?43420) - XSM may land as the first module. That's actually so= mething to solve on Xen side I think. It's just that so far we had just k= ernel and initrd, so that was non issue. >>> >>> Oh, did you mean Wei Liu's patch? >>> >>> I guess XSM may land as the third module (or the module after linux >>> kernel, if you don't have initrd) >>> >>> Yes, agree. (That's actually something to solve on Xen side) >>> >>> I guess xen can get xsm from a special initrd. so for now there is no= t >>> big problem on xsm. >>> >>> Please correct me if I misunderstand something. :-) >>> >>> Thanks! >>> >>> Back to this patch, is that OK for you, or any suggestion? Thanks ! >>> >> >> Yes, as this is dedicated Xen loader we should document this mandatory= >> order - first module must be kernel image, second module must be >> initrd. I do not think we need to mention possibility to load more >> than two modules until there is clear understanding how it can be done= >> without initrd. >=20 > Great thanks for your review, I have updated and sent the v3 patchset, > Hope I understood your suggestion correctly, Please check. :-) >=20 Your patches look fine. Let's wait for Andrei's opinion but I'm leaning to commit them >=20 >=20 --PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlbQW0sACgkQmBXlbbo5nOv+NQEAo9uD3FAOq/I5cqSfRZYP7v5r FLKFJUzOMJ/SUrsHJ5UA/18nf1URczMsCqKWTSTu/yizCvI4670KDDVmTv1XTdlS =0ckn -----END PGP SIGNATURE----- --PhsgC2RBUWwEP6JDmKb3PTphEQ2uofTnR--