From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aaqFV-0007kz-Dm for mharc-grub-devel@gnu.org; Tue, 01 Mar 2016 14:46:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaqFS-0007kX-Ru for grub-devel@gnu.org; Tue, 01 Mar 2016 14:46:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaqFP-0004cA-Ld for grub-devel@gnu.org; Tue, 01 Mar 2016 14:46:22 -0500 Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:36384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaqFP-0004c6-8m for grub-devel@gnu.org; Tue, 01 Mar 2016 14:46:19 -0500 Received: by mail-lb0-x22f.google.com with SMTP id x1so105522182lbj.3 for ; Tue, 01 Mar 2016 11:46:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=30gITuiMGi042GqR9s+wZMpjV5DjkOyhsOdaZS4Z6gE=; b=gf4sUU+O7jdNM46Vm2U3FOVwL98wQIOJfncBgYvTkYasc9wlxW3m3McZL2qjkMAXa5 u1cWEJRzTiU0Prwu5eku4RW8q2JyYPLPnhPIVsbOqJMpT02E3ymQVrbOfqwyWy+9TLu6 vea+WC1Ki+gXInVgZ4Pz9zfa4Xk0JpuglGED/VSTOlljEPIbTo3QMKnJtB7OiTS5IqBN ZxiCRIrrJkfPW7xHYkQ6uz4EiZ+IwoaOCbyScBp+f7hT2PAt80CQghbbMdwJB0zk1FAD IwXc2R+PYXXdq7ubUo8lcA/ZXQW0nab+u5T7ynPV2c8trzChR+cZLK2xFAHmb1pqnpeH YKvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=30gITuiMGi042GqR9s+wZMpjV5DjkOyhsOdaZS4Z6gE=; b=R1xm9xDBwOQB+r4E7XIURaEDahDpJ/R+Lo+Ce3xVrueMYjxmpaYNmjp5QJaQaaP7qg Sb90aZZx72vGzvlxb1gLH5475UL+mjAHNkFfCTNw4zwm8ypM6oNxqVrLaak+X9776hKa zU5PWH/6OOLuAEl+dn1C3Kscfu3nWSaC5Uv2zODpBbzuychzvwUS1Xg6JYuj+HCx+C/6 9gHBztEL6E416695WcGKPbcFcW6oyjwziKAfUi6wSt7KN4BZQ8DjY9TIwl9Ox4qzzTrv BYhlw9RAUDayw7zqptUkpieZ0H97Y+cWr6XpaXLRQnj9ZEvbOMtFqHXxI4ryAJMpRXw4 FlHQ== X-Gm-Message-State: AD7BkJLBs6x0ZG2kfW9NcOkAVMZpi5fwwY9pj8rU1dj0gXneHVdzYfg6yj7XL9R6IbAzzA== X-Received: by 10.112.172.42 with SMTP id az10mr8651653lbc.128.1456861578391; Tue, 01 Mar 2016 11:46:18 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id mt7sm331400lbb.25.2016.03.01.11.46.16 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 Mar 2016 11:46:17 -0800 (PST) Subject: Re: [PATCH 1/2] disk: Add support for device-specific malloc function To: grub-devel@gnu.org References: <1455898714-25127-1-git-send-email-leif.lindholm@linaro.org> <1455898714-25127-2-git-send-email-leif.lindholm@linaro.org> <56CABF64.7020003@gmail.com> <20160222140255.GO1159@bivouac.eciton.net> <56CB3DB9.4050102@gmail.com> <20160224115921.GU1159@bivouac.eciton.net> <20160224135738.GV1159@bivouac.eciton.net> <56CDEB27.6060606@gmail.com> From: Andrei Borzenkov X-Enigmail-Draft-Status: N1110 Message-ID: <56D5F188.6010306@gmail.com> Date: Tue, 1 Mar 2016 22:46:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22f X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 19:46:24 -0000 01.03.2016 20:11, Leif Lindholm пишет: > On 24 February 2016 at 17:40, Andrei Borzenkov wrote: >> 24.02.2016 16:57, Leif Lindholm пишет: >>> On Wed, Feb 24, 2016 at 03:09:13PM +0300, Andrei Borzenkov wrote: >>>>>> Could you test attached patch with your alignment fixes on top. This >>>>>> implements my idea of using shared buffers. Seems to work in naive testing. >>>>> >>>>> Testing this with a grub-mkstandalone image, I get: >>>>> >>>>> kern/dl.c:556: flushing 0x10f1 bytes at 0x9ffb5ac20 >>>>> kern/dl.c:649: module name: tar >>>>> kern/dl.c:650: init function: 0x9ffb5b220 >>>>> kern/disk.c:217: Opening `memdisk'... >>>>> kern/fs.c:56: Detecting tarfs... >>>>> >>>>> And then spectacular crash in UEFI due to an EL2 translation fault. >>>> >>>> To be sure - is it with my patch alone or with your patches? If some >>>> more patches are used - could you send exact diff to trunk to avoid >>>> misunderstanding? >>> >>> Double checked with only your patch on top of >>> 1b782e902e69516f82158203674d4951a40c82d4 (previously running with >>> _only_ my alignment fixup in efidisk.c). Same behaviour. >> >> I cannot reproduce it on x86_64 (also with mm-debug enabled) and I do >> not know how to load standalone image on ppc; is it possible to use QEMU >> to run ARM64 (I assume you have it)? If not what are options to test it? >> >> Anyway, there was one problem I fixed later (although I did not get any >> issue before as well), I attach updated version. Thank you for testing! > > I can confirm that: > 1) The first patch exhibits no bad behaviour on QEMU [1]. > 2) The second patch exhibits no bad behaviour on either QEMU nor HW. > > This still generates fixups in efidisk for each call though. Of course; it was intended to add framework for direct-to-cache IO, it did not change alignment. > Could I rework my disk->malloc patch on top of this for 2.02 release? > Of course! Not sure whether it is 2.02 material though, but we can keep it in next then. Hopefully 2.03 won't take so long :) > / > Leif > > [1] qemu-system-aarch64 -m 1024 -cpu cortex-a57 -M virt -bios > QEMU_EFI.fd -nographic -hda fat:fat/ > With QEMU_EFI.fd from > http://releases.linaro.org/components/kernel/uefi-linaro/16.02/debug/qemu64/ > And fat/ being a directory holding the image generated with grub-mkstandalone. > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >