From: Andrei Borzenkov <arvidjaar@gmail.com>
To: David Michael <fedora.dm0@gmail.com>
Cc: Vladimir Serbinenko <phcoder@gmail.com>,
The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH v5 2/2] Add a module for retrieving SMBIOS information
Date: Tue, 8 Mar 2016 08:02:31 +0300 [thread overview]
Message-ID: <56DE5CE7.6030005@gmail.com> (raw)
In-Reply-To: <CAEvUa7k1qmV9JvrhzQsDb3O6fKbKxq-z=r0q3YCKyAWup+YZzw@mail.gmail.com>
03.03.2016 07:13, David Michael пишет:
> On Wed, Mar 2, 2016 at 2:08 PM, Andrei Borzenkov <arvidjaar@gmail.com> wrote:
>> Two nitpicks otherwise looks good. Thanks!
>
> Thanks for reviewing these again. I agree with your suggestions, but
> do they warrant another updated patch, or can those changes just be
> squashed onto this commit?
>
Could you send final version with all changes applied; it makes it
easier to review and apply.
> Also, since sending this, Leif Lindholm has proposed a patch for
> sharing the EFI table lookup code, which is functionality used by this
> module. Is that something that would be included in 2.02? Should I
> make a quick update to this to use the new function?
>
That's probably post-2.02 change.
prev parent reply other threads:[~2016-03-08 5:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 19:12 [PATCH v5 2/2] Add a module for retrieving SMBIOS information David Michael
2016-03-02 19:08 ` Andrei Borzenkov
2016-03-03 4:13 ` David Michael
2016-03-08 5:02 ` Andrei Borzenkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DE5CE7.6030005@gmail.com \
--to=arvidjaar@gmail.com \
--cc=fedora.dm0@gmail.com \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).