From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ad9n7-0001VT-7r for mharc-grub-devel@gnu.org; Tue, 08 Mar 2016 00:02:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad9n4-0001UK-Ka for grub-devel@gnu.org; Tue, 08 Mar 2016 00:02:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad9n1-0007L9-ET for grub-devel@gnu.org; Tue, 08 Mar 2016 00:02:38 -0500 Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:34024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad9n1-0007L1-78 for grub-devel@gnu.org; Tue, 08 Mar 2016 00:02:35 -0500 Received: by mail-lb0-x22e.google.com with SMTP id xr8so4721756lbb.1 for ; Mon, 07 Mar 2016 21:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=DFxk4ErDvCh1GPl+MONGplbb2+BoNP+82k1SrdAj9O8=; b=Ss8FqgUppg7uRwG/iLfQRciSvBlT535g9cSdSZmS122DWxNNbxKlkSkokfHC6IXdnL 0BnaDutTCLn2QfCZ/RO0XxnhVG+M83pwzZL07vHEEoqBC9YX43xQnaoOkFF53m/BMH2N viUQ0QZu3Ps6x0+X6KC8P0l5pFzetPBKKoCOmyY0QbCNgJJK2k1fheJVwv4w1heUkcIO V4DbPUq9xQgDWzexo9fwS4pxlnr6HQGeKPYgSYAoHmEXdvBZaczmrLVkKZod3IN63dws 9K1lYxpJ8QimdsqjF9M43FnCIYtgxBT6WLeQHXaURmZ5gvfjYLWJTGh40H9/7LKdX+2E V7Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=DFxk4ErDvCh1GPl+MONGplbb2+BoNP+82k1SrdAj9O8=; b=CUv23Idg6KkFBS0WpITFJN+eNiVUlr/z5kzDnansa3jrSEFvYESPddCcYstwWL+EsN lIbRZQio80XiwglynxIJ7tm/6YQc07g6YWcgWpcgBY62VJAiDvmMy1+3spbtLo4MifL4 BrJuNAKlo+R50shfp3/hxE4jC4/lVRCPsC3xuzK6hvA6iiuuXZI2QcvecwAr/7d3Lr8W bWQITpNpynNIQpKSgMpnLIKYG1r8o6gWr7buxTHSWcH2UuiFUWYuT4senabxG+QHtuK3 p2uZP7HXE4t+XdEK3fztaalvMhdECzUmlRql0sXRk+oVY4dSR8wgv08D3ph0aZtjU+A2 p83A== X-Gm-Message-State: AD7BkJLJsfnt/O9jwpCJEfOIRJNR/AsXG+RU4kEZ3APODwOSpV6NDjRkOaHmc37oikPIzQ== X-Received: by 10.25.40.210 with SMTP id o201mr6991506lfo.44.1457413354258; Mon, 07 Mar 2016 21:02:34 -0800 (PST) Received: from [192.168.1.42] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id k65sm165084lfe.41.2016.03.07.21.02.32 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Mar 2016 21:02:33 -0800 (PST) Subject: Re: [PATCH v5 2/2] Add a module for retrieving SMBIOS information To: David Michael References: <87y4af9ox0.fsf@gmail.com> <56D73A44.6010602@gmail.com> From: Andrei Borzenkov Message-ID: <56DE5CE7.6030005@gmail.com> Date: Tue, 8 Mar 2016 08:02:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22e Cc: Vladimir Serbinenko , The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 05:02:39 -0000 03.03.2016 07:13, David Michael пишет: > On Wed, Mar 2, 2016 at 2:08 PM, Andrei Borzenkov wrote: >> Two nitpicks otherwise looks good. Thanks! > > Thanks for reviewing these again. I agree with your suggestions, but > do they warrant another updated patch, or can those changes just be > squashed onto this commit? > Could you send final version with all changes applied; it makes it easier to review and apply. > Also, since sending this, Leif Lindholm has proposed a patch for > sharing the EFI table lookup code, which is functionality used by this > module. Is that something that would be included in 2.02? Should I > make a quick update to this to use the new function? > That's probably post-2.02 change.