From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1adCTu-0008JN-VN for mharc-grub-devel@gnu.org; Tue, 08 Mar 2016 02:55:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCTr-0008Bx-N7 for grub-devel@gnu.org; Tue, 08 Mar 2016 02:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adCTo-0000Ow-8i for grub-devel@gnu.org; Tue, 08 Mar 2016 02:54:59 -0500 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:36180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCTn-0000Oq-S7 for grub-devel@gnu.org; Tue, 08 Mar 2016 02:54:56 -0500 Received: by mail-lb0-x22a.google.com with SMTP id x1so8201102lbj.3 for ; Mon, 07 Mar 2016 23:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=v9nKN3VgiWo8q7tCCMUFq1C/UOjCzUCaaOzK/m/spOY=; b=iCHJafzr2QiOaIqpsV7nKBgNSK8NeW30VExlQXkgJj6cE9bSm1M66wZSRgtLtZSiyb 0Tpmt6Hw2qhtpIpdtOshuGAchaj/TQVwwXOKQ91gO/OhKwdi2U58+GTRZ6td+v5m/Eum ys335PHfnqFPZhA+lLV70eBqSTh2PsxCgwjqMUamxyUgO3tMXY0BPYNH81DAaBViksw4 4c8nBc/x3dxqd52Sk1U0IgTMIGzco0Pe79OSWahbojfcB+86s1OZ2JAM37qnBw8Rg2CP TtDVyv+1m3AEUlwGBxuDNfdQkLpSDSwJPGZp4jIfKMj0Jgio6xMgV7KRLSaksA5muBrj CdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=v9nKN3VgiWo8q7tCCMUFq1C/UOjCzUCaaOzK/m/spOY=; b=NuOS5zJMrE8javYMlkDb4LH5q9N4s2pNgtk4riZLqqEDfOiKx5etmg0U1vNdzgF41T s9tLe5NNQdAjAqSow578rAC530YmROojEsQ+uO1vrCnfjHChinpIbr1sqU0rdcDIa6OY 8HFDYAMxn75ZVn0qhwpnwmL3+ioVwOc0x0Uz7K6eIAp8K8O/VxzQTObCiCNvd7KlJ5Y4 SZcXIUgLKBiT2yo3FBXU6eGSryuRofpIE0HfrRysMVPzpabOY2vX1TV36CoC+/3/tR+A qzsU2A1DVcG+PKNTNhfSnhiuObBFte/KPdV0Usf2Qd0YiTCZabu+2qmBT8COkKFNsVAf dBLQ== X-Gm-Message-State: AD7BkJJvevOb5d361LEUc6t7vyB40DaJ+AL2SC6uS6qJGVTIFs8f3pFFcYGYi/J/Slj80g== X-Received: by 10.112.126.162 with SMTP id mz2mr8681091lbb.71.1457423694807; Mon, 07 Mar 2016 23:54:54 -0800 (PST) Received: from [192.168.1.42] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id xf10sm260117lbb.23.2016.03.07.23.54.53 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Mar 2016 23:54:53 -0800 (PST) Subject: Re: [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi To: Fu Wei References: <1456485211-32695-1-git-send-email-fu.wei@linaro.org> <1456485211-32695-5-git-send-email-fu.wei@linaro.org> <56D1DC36.1020603@gmail.com> From: Andrei Borzenkov X-Enigmail-Draft-Status: N1110 Message-ID: <56DE854C.9010506@gmail.com> Date: Tue, 8 Mar 2016 10:54:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22a Cc: The development of GNU GRUB , xen-devel@lists.xensource.com, Ian Campbell , Vladimir Serbinenko , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List , Jon Masters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 07:55:01 -0000 07.03.2016 11:22, Fu Wei пишет: > Hi Andrei, > > On 28 February 2016 at 00:44, Fu Wei wrote: >> Hi Andrei >> >> On 28 February 2016 at 01:26, Andrei Borzenkov wrote: >>> 26.02.2016 14:13, fu.wei@linaro.org пишет: >>>> From: Fu Wei >>>> >>>> delete: xen_linux, xen_initrd, xen_xsm >>>> add: xen_module >>>> >>>> This update bases on >>>> commit 0edd750e50698854068358ea53528100a9192902 >>>> Author: Vladimir Serbinenko >>>> Date: Fri Jan 22 10:18:47 2016 +0100 >>>> >>>> xen_boot: Remove obsolete module type distinctions. >>>> >>>> Signed-off-by: Fu Wei >>>> --- >>>> docs/grub.texi | 33 ++++++++++----------------------- >>>> 1 file changed, 10 insertions(+), 23 deletions(-) >>>> >>>> diff --git a/docs/grub.texi b/docs/grub.texi >>>> index 82f6fa4..3fbdd99 100644 >>>> --- a/docs/grub.texi >>>> +++ b/docs/grub.texi >>>> @@ -3861,9 +3861,7 @@ you forget a command, you can run the command @command{help} >>>> * videoinfo:: List available video modes >>>> @comment * xen_*:: Xen boot commands >>>> * xen_hypervisor:: Load xen hypervisor binary >>>> -* xen_linux:: Load dom0 kernel for xen hypervisor >>>> -* xen_initrd:: Load dom0 initrd for dom0 kernel >>>> -* xen_xsm:: Load xen security module for xen hypervisor >>>> +* xen_module:: Load xen modules for xen hypervisor >>>> @end menu >>>> >>>> >>>> @@ -5141,30 +5139,19 @@ verbatim as the @dfn{kernel command-line}. Any other binaries must be >>>> reloaded after using this command. >>>> @end deffn >>>> >>>> -@node xen_linux >>>> -@subsection xen_linux >>>> +@node xen_module >>>> +@subsection xen_module >>>> >>>> -@deffn Command xen_linux file [arguments] >>>> -Load a dom0 kernel image for xen hypervisor at the booting process of xen. >>>> +@deffn Command xen_module [--nounzip] file [arguments] >>>> +Load a module for xen hypervisor at the booting process of xen. >>>> The rest of the line is passed verbatim as the module command line. >>> >>> == >>>> +On i386, the modules will be identified by Multiboot(2) protocol. >>>> +On arm64, each module will be identified by the order in which the >>>> +modules are added. >>> >>> I think it is better to skip it entirely. It is not really correct - >>> neither multiboot protocol provides any module identification (Xen >>> probes module types), nor is i386 using multiboot2, nor can all modules >>> be probed, so order still matters. To avoid confusion I'd simply >>> replaced the above three lines with >>> >>> Modules should be loaded in the following order: >>> >>>> +The 1st module: dom0 kernel image >>>> +The 2nd module: dom0 ramdisk (optional) >>> >>> This covers both supported platforms without going into too deep >>> details; if you and Vladimir are OK, I'll commit with this change. >> >> Thank you very much! >> Sorry I am not familiar with xen on i386, so maybe I misunderstand this. >> So please commit with your change, Thanks for your correction :-) > > I just fetched the mainline GRUB, i would like to know why this > patchset haven't been applied? > Anything I need to do(improve it or post a new patchset according to > your suggestion) for this patchset? > Sorry for delay. It is not really about your patchset, but we need some decision about loading additional modules/lack of initrd on ARM. Until then I'd rather avoid committing to any high-level configuration support that will require even more backward compatible hacks later. As it stands now either Xen needs to support autodetection or we need to revert to providing module type explicitly.