From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1adL8k-0007D4-KK for mharc-grub-devel@gnu.org; Tue, 08 Mar 2016 12:09:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adL8h-0007CD-6F for grub-devel@gnu.org; Tue, 08 Mar 2016 12:09:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adL8c-0005dF-3P for grub-devel@gnu.org; Tue, 08 Mar 2016 12:09:43 -0500 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]:34323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adL8b-0005d7-Mh for grub-devel@gnu.org; Tue, 08 Mar 2016 12:09:38 -0500 Received: by mail-lb0-x234.google.com with SMTP id xr8so26416858lbb.1 for ; Tue, 08 Mar 2016 09:09:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=v1ZJ84+GzZ2y2cY3orKJa0McsNRqvILYb1LrZqcHR8w=; b=D092LFPHHdDWEosvSZaV1toIP+LtHba4WC6Kqor+qDgbABHHJWsq6v0HrpkCt+VaFa YvOe0DECzIjWfYJEQrZqZUTCQk6+JF/UOrGeU0yrHY7CtE/HbFH0oYoZimG5BnXm7zse czT8X3AgW6ClF8oArUKZLUS9NDvoBHVWeezYYncvmet09HzQgU5BjoPW7Z9iBLnBdSuy 8hOT6R1F44xXWPzvIX5pBMQ37ZHevmgC6C3J/z/DZFycxVZc5KVx15ZQrSQMmLBKpOuV A0UQXIlAMcfRVOuZ9Nl4XLBXJvRxUhcPWXJzlA/0yhO1MCUtSPrJornlG4/71u1VDPbN 8Mxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=v1ZJ84+GzZ2y2cY3orKJa0McsNRqvILYb1LrZqcHR8w=; b=evFVh89W4gdoK6HJ4ZUSwDY6kvoDrAEEOqK8v5PW3d/bmUWXkkDCkNCt1cgvnNfSsO uPT9z8WMJdSUKSLso87K9xeguN9IOejDeOQzzboaO5zufPJTNv1h2chSNEBgLlP8fdwv /U7ihe68CvMKpq1YCM3JQF8s86eJ7IMcqycy4afCCgFFq638sH7uv2D9Hx/kiNwAzsER OyGTJexND9nNLmLtcndPTguwh+4aOfSt8oS6CwXzc032WQdiIhDFBeVsMfF1dTRz+3DN O9/WEd74UJ2fIejZKl/BenlvnOt/zMjnsUQ8tXs/9wT2zhrOEI1bYTUUYUST9Gv2dXld fWyw== X-Gm-Message-State: AD7BkJLQWHo6v0vJfUIjTR84ScLPFS0SrqKfujavAVmgKQE/vmZ7JPPXUIs6bCPfSrv+ww== X-Received: by 10.112.151.134 with SMTP id uq6mr8005635lbb.18.1457456976434; Tue, 08 Mar 2016 09:09:36 -0800 (PST) Received: from [192.168.1.42] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id d131sm632324lfg.27.2016.03.08.09.09.34 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2016 09:09:35 -0800 (PST) Subject: Re: [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi To: Fu Wei References: <1456485211-32695-1-git-send-email-fu.wei@linaro.org> <1456485211-32695-5-git-send-email-fu.wei@linaro.org> <56D1DC36.1020603@gmail.com> <56DE854C.9010506@gmail.com> From: Andrei Borzenkov Message-ID: <56DF074E.1020803@gmail.com> Date: Tue, 8 Mar 2016 20:09:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::234 Cc: The development of GNU GRUB , xen-devel@lists.xensource.com, Ian Campbell , Vladimir Serbinenko , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List , Jon Masters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 17:09:44 -0000 08.03.2016 19:37, Fu Wei пишет: > Hi Andrei, > > On 8 March 2016 at 14:54, Andrei Borzenkov wrote: >> 07.03.2016 11:22, Fu Wei пишет: >>> Hi Andrei, >>> >>> On 28 February 2016 at 00:44, Fu Wei wrote: >>>> Hi Andrei >>>> >>>> On 28 February 2016 at 01:26, Andrei Borzenkov wrote: >>>>> 26.02.2016 14:13, fu.wei@linaro.org пишет: >>>>>> From: Fu Wei >>>>>> >>>>>> delete: xen_linux, xen_initrd, xen_xsm >>>>>> add: xen_module >>>>>> >>>>>> This update bases on >>>>>> commit 0edd750e50698854068358ea53528100a9192902 >>>>>> Author: Vladimir Serbinenko >>>>>> Date: Fri Jan 22 10:18:47 2016 +0100 >>>>>> >>>>>> xen_boot: Remove obsolete module type distinctions. >>>>>> >>>>>> Signed-off-by: Fu Wei >>>>>> --- >>>>>> docs/grub.texi | 33 ++++++++++----------------------- >>>>>> 1 file changed, 10 insertions(+), 23 deletions(-) >>>>>> >>>>>> diff --git a/docs/grub.texi b/docs/grub.texi >>>>>> index 82f6fa4..3fbdd99 100644 >>>>>> --- a/docs/grub.texi >>>>>> +++ b/docs/grub.texi >>>>>> @@ -3861,9 +3861,7 @@ you forget a command, you can run the command @command{help} >>>>>> * videoinfo:: List available video modes >>>>>> @comment * xen_*:: Xen boot commands >>>>>> * xen_hypervisor:: Load xen hypervisor binary >>>>>> -* xen_linux:: Load dom0 kernel for xen hypervisor >>>>>> -* xen_initrd:: Load dom0 initrd for dom0 kernel >>>>>> -* xen_xsm:: Load xen security module for xen hypervisor >>>>>> +* xen_module:: Load xen modules for xen hypervisor >>>>>> @end menu >>>>>> >>>>>> >>>>>> @@ -5141,30 +5139,19 @@ verbatim as the @dfn{kernel command-line}. Any other binaries must be >>>>>> reloaded after using this command. >>>>>> @end deffn >>>>>> >>>>>> -@node xen_linux >>>>>> -@subsection xen_linux >>>>>> +@node xen_module >>>>>> +@subsection xen_module >>>>>> >>>>>> -@deffn Command xen_linux file [arguments] >>>>>> -Load a dom0 kernel image for xen hypervisor at the booting process of xen. >>>>>> +@deffn Command xen_module [--nounzip] file [arguments] >>>>>> +Load a module for xen hypervisor at the booting process of xen. >>>>>> The rest of the line is passed verbatim as the module command line. >>>>> >>>>> == >>>>>> +On i386, the modules will be identified by Multiboot(2) protocol. >>>>>> +On arm64, each module will be identified by the order in which the >>>>>> +modules are added. >>>>> >>>>> I think it is better to skip it entirely. It is not really correct - >>>>> neither multiboot protocol provides any module identification (Xen >>>>> probes module types), nor is i386 using multiboot2, nor can all modules >>>>> be probed, so order still matters. To avoid confusion I'd simply >>>>> replaced the above three lines with >>>>> >>>>> Modules should be loaded in the following order: >>>>> >>>>>> +The 1st module: dom0 kernel image >>>>>> +The 2nd module: dom0 ramdisk (optional) >>>>> >>>>> This covers both supported platforms without going into too deep >>>>> details; if you and Vladimir are OK, I'll commit with this change. >>>> >>>> Thank you very much! >>>> Sorry I am not familiar with xen on i386, so maybe I misunderstand this. >>>> So please commit with your change, Thanks for your correction :-) >>> >>> I just fetched the mainline GRUB, i would like to know why this >>> patchset haven't been applied? >>> Anything I need to do(improve it or post a new patchset according to >>> your suggestion) for this patchset? >>> >> >> Sorry for delay. It is not really about your patchset, but we need some >> decision about loading additional modules/lack of initrd on ARM. Until >> then I'd rather avoid committing to any high-level configuration support >> that will require even more backward compatible hacks later. >> >> As it stands now either Xen needs to support autodetection or we need to >> revert to providing module type explicitly. > > So speaking of loading additional modules/lack of initrd on ARM, I thinks that > will (only) affect loading XSM. > For this, I have discussed of that with Julien, I think : > (1) the first module must be kernel > (2) the second module must be initrd, if we have initrd > (3) Start from the 2nd module, XEN will detect that if the module is a XSM by > the XSM binary signature. if we get XSM as the second module, that > means we have not initrd. > If that's the plan, excellent. Vladimir, is it OK to commit then? > please correct me if I misunderstand it > > :-) >