grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>,
	The development of GNU GRUB <grub-devel@gnu.org>
Cc: "kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH 1/3] push/pop errno in initrd read file path
Date: Fri, 11 Mar 2016 13:13:36 -0500	[thread overview]
Message-ID: <56E30AD0.80702@fb.com> (raw)
In-Reply-To: <CAEaD8JN_vuGx6oz8+5Mch-GvXw4tTPYTU2zz9mhdZ1CZhnQ5Dw@mail.gmail.com>

On 03/11/2016 12:23 PM, Vladimir 'phcoder' Serbinenko wrote:
>
>
> On Friday, March 11, 2016, Josef Bacik <jbacik@fb.com
> <mailto:jbacik@fb.com>> wrote:
>
>     If you try to load an initrd from http and it errors out we will
>     free the initrd
>     context but continue on because net_tcp_socket_close() will reset
>     the grub_errno
>     as will grub_initrd_close().  So we'll lose the errno and return
>     GRUB_ERR_NONE
>     instead of the original error.  Add push/pulls to the appropriate
>     places so we
>     don't lose our errno.  Thanks,
>
> Close functions shouldn't do this. Can you fix them instead? Also please
> add [2.02] to the subjectwhen appropriate, like in this case.
>

So do we not want close functions to do grub_error() at all?  Seems like 
there may be some cases where we want to know there was an error closing 
a tcp socket or the initrd?  Maybe not, just want to make sure before I 
go make these two functions void.  Thanks,

Josef



  reply	other threads:[~2016-03-11 18:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 16:28 [PATCH 1/3] push/pop errno in initrd read file path Josef Bacik
2016-03-11 16:28 ` [PATCH 2/3] tcp: add a dprintf for opening tcp connections Josef Bacik
2016-03-11 16:28 ` [PATCH 3/3] pxenet: process transmit interrupts when out of resources Josef Bacik
2016-03-12  6:20   ` Andrei Borzenkov
2016-03-11 17:23 ` [PATCH 1/3] push/pop errno in initrd read file path Vladimir 'phcoder' Serbinenko
2016-03-11 18:13   ` Josef Bacik [this message]
2016-03-11 19:34     ` Vladimir 'phcoder' Serbinenko
2016-03-11 20:34       ` Josef Bacik
2016-03-11 22:00         ` Vladimir 'phcoder' Serbinenko
2016-03-12  7:01           ` Andrei Borzenkov
2016-03-15 17:26             ` Vladimir 'phcoder' Serbinenko
2016-11-10 12:49 ` Daniel Kiper
2016-11-18 14:51   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E30AD0.80702@fb.com \
    --to=jbacik@fb.com \
    --cc=grub-devel@gnu.org \
    --cc=kernel-team@fb.com \
    --cc=phcoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).