From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aeRx1-0007qz-MW for mharc-grub-devel@gnu.org; Fri, 11 Mar 2016 13:38:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeRwx-0007m6-Ow for grub-devel@gnu.org; Fri, 11 Mar 2016 13:38:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeRwt-0000QI-Df for grub-devel@gnu.org; Fri, 11 Mar 2016 13:38:11 -0500 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:34196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeRwt-0000Q9-1B for grub-devel@gnu.org; Fri, 11 Mar 2016 13:38:07 -0500 Received: by mail-lb0-x22d.google.com with SMTP id xr8so161935210lbb.1 for ; Fri, 11 Mar 2016 10:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=PqtVQzvl3bSMNzX836ca8R0RaBJ0QAsGFSmkJxAbVbc=; b=GNZG3JPl5eQ2JSLtuPcMiQpKHF5IoirF03Iz0hd6W5KGqP4DUWdhhPGD4ZWrq7siTr D8gwxX4YqQz6GU7KKkBaxboUXnu6jLkK63N2ZyUlZ+SmM9gvetZiXYEma4ffdbIEmxJs yt1bfgsqDQoxJIw6ckaSYJoR5yaibFPXelUOvQmdxxf+CxRoRK2rkAEBUEyzK0rxtsB1 EZF+O4AplnwAG4ZCBnwurwC91mhi5MbBwCUGcv7oyEGcGithA/5qKVtTxMnJw+MMlttj cg3aWLIyReVvsOcMqWlu9usbi+zGhEmnmDaKDev5p/WX9huqwvPtgAiBdRK6PcOEqnWv Z06g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=PqtVQzvl3bSMNzX836ca8R0RaBJ0QAsGFSmkJxAbVbc=; b=fty8q51YKFnM3RAPAcQVfqf1XBqrWh4Gdi+Kls7XryZWTdD032Q3CcArwA8zaUtwZA Q6LaHCJoCh7hJJoSK9iWc8VtqbKCKuGTN5g0ojnOrgZa9fEDeyOQzVvU+c91EVzzZPAa a3P/LgWMeMn7VQ8uDqRa0SQxJKsxwdUnt83fb7c9bLafkS6mE0o6SZUO+yYR4iKw9P6F bSuxaNysvGZYEcVQBBBBLBvKN1B1RrLLD0jqZOJG+PVVI5Ik6MK+WnWX7eS8CJtqXml/ KPlWGmlIqSMnwoPtMfFWck328Ns/S/OSNJ+mX0C/d/xFqn/v/EWdAU/1mvzL6/5lbLRF FoHA== X-Gm-Message-State: AD7BkJLflHowPmamhyusEEKtxuz3IA/nvNZ1hnZLkvuW0ITIXx04k14che18DfDkyUAM5Q== X-Received: by 10.112.50.144 with SMTP id c16mr3711360lbo.128.1457721486188; Fri, 11 Mar 2016 10:38:06 -0800 (PST) Received: from [192.168.1.42] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id cc7sm1516173lbd.11.2016.03.11.10.38.04 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Mar 2016 10:38:05 -0800 (PST) Subject: Re: Bugs and tasks for 2.02[~rc1] To: Peter Jones References: <20160304200641.GC27106@redhat.com> <56DA9AE8.3010006@gmail.com> <20160307190016.GA13163@redhat.com> <56DF127C.10305@gmail.com> <20160308214738.GA31913@redhat.com> From: Andrei Borzenkov X-Enigmail-Draft-Status: N1110 Message-ID: <56E3108C.6060900@gmail.com> Date: Fri, 11 Mar 2016 21:38:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160308214738.GA31913@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22d Cc: Vladimir 'phcoder' Serbinenko , Colin Watson , The development of GRUB 2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 18:38:13 -0000 09.03.2016 00:47, Peter Jones пишет: >>> >>>>> e704140 Move bash completion script (#922997) >>>> >>>> Well, this is obvious compatibility question. Is there any way to detect >>>> it at configure time? Does bash have pkg-config or similar? >>> >>> I don't see anything obviously like that, unfortunately, and I'm not >>> really sure in what version they switched it. >>> >> >> There is. >> >> bor@bor-Latitude-E5450:~/src/systemd$ pkg-config --variable >> completionsdir bash-completion >> /usr/share/bash-completion/completions >> >> Could you add configure.ac option that checks for it and defaults to >> current value? > > Gah, it's in bash-completion not in bash. Well, anyway: sure thing, > I'll fix up configure.ac, though I'm not that well versed in autoconf. > Currently what I have is here, and I welcome any feedback: > https://github.com/vathpela/grub2-fedora/commit/04844de3eb04f > Default should be current value. This should use PKG_CHECK_EXISTS which also correctly handles missing pkg-config at configure time. It is OK to require pkg-config for building from GIT though. We may want to make it into --with-bashcompletiondir so users can set it also if pkg-config and/or bash-completion are not available. Also please print bashcompletiondir value in final summary. > Note that I've built that version but not actually tested it yet. > ... > >>>>> 73545c7 Add GRUB_DISABLE_UUID. >>>> >>>> If name as detected by GRUB is correct, there will be no search because >>>> hints will be correct (just direct verification that device is indeed >>>> correct). If name is wrong you need search, otherwise you fail to boot >>>> or boot wrong binary. I do not see what we gain here. >>> >>> So, the bug report from our QA dept believed >>> GRUB_DISABLE_LINUX_UUID=true should accomplish this, and that it's >>> pointless without it. And I think they've kind of got a point, since if >>> the user has the problem GRUB_DISABLE_LINUX_UUID was meant to solve, >>> there's no reason to believe they can't have the same problem with the >>> other filesystem. We made them separate settings because one is about >>> /boot and one is about / , but fundamentally they're both doing parts of >>> the same thing. >>> >> >> Not really. Linux UUIDs cannot be used without initrd, so if you have >> monolithic kernel without initrd you cannot really use UUIDs for root. >> So you can disable them in this case. >> >> It really needs some more details about problem it was intended to solve. > > Original bug is here: > https://bugzilla.redhat.com/show_bug.cgi?id=1027833 . I'm not > personally very invested in this one, except inasmuch as it's in my > tree and I'd like that diff to get smaller over time... :) > So user has /boot UUID changing all the time? Unfortunately this bug does not really explain why it happens. I mean, normally UUID of /boot changes when you re-create filesystem, but then your /boot/grub is lost as well together with grub.cfg and you need to create it again at which point you get new UUID.