grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] http: fix superfluous null line in range request header
Date: Sat, 9 Apr 2016 07:08:58 +0300	[thread overview]
Message-ID: <5708805A.10809@gmail.com> (raw)
In-Reply-To: <20160406101914.GA10786@linux-9gqx.suse>

06.04.2016 13:19, Michael Chang пишет:
> At least the apache sever is very unhappy with that extra null line and will
> take more than ten seconds in responding to each range request, which slows
> down a lot the entire http file transfer process or even time out.

Applied. Thanks!

> ---
>  grub-core/net/http.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/grub-core/net/http.c b/grub-core/net/http.c
> index 4684f8b..a7c5101 100644
> --- a/grub-core/net/http.c
> +++ b/grub-core/net/http.c
> @@ -381,9 +381,8 @@ http_establish (struct grub_file *file, grub_off_t offset, int initial)
>        ptr = nb->tail;
>        grub_snprintf ((char *) ptr,
>  		     sizeof ("Range: bytes=XXXXXXXXXXXXXXXXXXXX-"
> -			     "\r\n"
>  			     "\r\n"),
> -		     "Range: bytes=%" PRIuGRUB_UINT64_T "-\r\n\r\n",
> +		     "Range: bytes=%" PRIuGRUB_UINT64_T "-\r\n",
>  		     offset);
>        grub_netbuff_put (nb, grub_strlen ((char *) ptr));
>      }
> 



      reply	other threads:[~2016-04-09  4:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 10:19 [PATCH] http: fix superfluous null line in range request header Michael Chang
2016-04-09  4:08 ` Andrei Borzenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5708805A.10809@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).