From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aokCo-0006jW-Ff for mharc-grub-devel@gnu.org; Sat, 09 Apr 2016 00:09:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aokCm-0006fU-96 for grub-devel@gnu.org; Sat, 09 Apr 2016 00:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aokCj-0005CG-1s for grub-devel@gnu.org; Sat, 09 Apr 2016 00:09:04 -0400 Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:33362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aokCi-0005CB-Pa for grub-devel@gnu.org; Sat, 09 Apr 2016 00:09:00 -0400 Received: by mail-lf0-x229.google.com with SMTP id e190so96792627lfe.0 for ; Fri, 08 Apr 2016 21:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=bTWOZ+DKI3yDLjjQOTliHO+Nyx9TTOILUfrn5D6oaOQ=; b=V8kOIKHDQ617unNu/zexqeZ1jqRz44jLAlafmiFJ9yChau5r2RFJaSWNmtCKlUImGU YnAcA4dyB9m4AoVrwAryIxcgbwsHPJZ5NPZFUDElr1jyuyjnTRGd4AmrIqjUIwbRlyJA h4RweYKVRSs+tol87Yxa5sXD1mjBRM8Q8s6YakLn8W9ylCJF30Z3nB2tgoec1j2xflqB Rr1nsgaSziUBwDR9iH2gFkDmAWFp8ka7ir7d6gFpaj4wU/LkAcYNY93UXBOLyv2QopFu 06y0lf5Bq1RpxgGgXxvSq0N4hMudzNYORr5w5bZG0ZgVbHC/FjXAobOXcYXx6xoHML1n uGGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=bTWOZ+DKI3yDLjjQOTliHO+Nyx9TTOILUfrn5D6oaOQ=; b=JVDk1rVsESfTe9r+fVR3WmdAYDlBVAuRc/vXxH+rYJFRKtaPzXfTAkjmbicDBLHCoE YmYzyL8hDrFuIemDsLmhOtoRgZY25bqYjFuNvQShtwcjD4StLhMvZkFOwCRRUKyhy6uU UE0QEHX/rB59ecHWL4NlvcwabkLhjtee+3WRzIz/Tfh9hlC1fZGCjc8bHCIDjUa+6BQ+ AfEAaPAKRszVaoKBjGjyygyZ1/ohRj2xdsmaykbNpj5mVyWZtHWFH6efmk2M94rTDrEE ejeP3mrIgL0W2h4cn4qo+iIvTeO53fNJrjWN9OZjwTZA4cbPdzIiVNI1kejhwthzGLct htlQ== X-Gm-Message-State: AD7BkJL8Yp4vMdZZRiYfDj4rVj6LwDL5LQDmK09JpPPgkjVz662U28VbklamhmuyqcdEHQ== X-Received: by 10.25.143.203 with SMTP id r194mr4831329lfd.154.1460174940094; Fri, 08 Apr 2016 21:09:00 -0700 (PDT) Received: from [192.168.1.42] (ppp109-252-90-50.pppoe.spdop.ru. [109.252.90.50]) by smtp.gmail.com with ESMTPSA id t2sm2503879lbr.45.2016.04.08.21.08.59 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Apr 2016 21:08:59 -0700 (PDT) Subject: Re: [PATCH] http: fix superfluous null line in range request header To: grub-devel@gnu.org References: <20160406101914.GA10786@linux-9gqx.suse> From: Andrei Borzenkov Message-ID: <5708805A.10809@gmail.com> Date: Sat, 9 Apr 2016 07:08:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160406101914.GA10786@linux-9gqx.suse> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2016 04:09:05 -0000 06.04.2016 13:19, Michael Chang пишет: > At least the apache sever is very unhappy with that extra null line and will > take more than ten seconds in responding to each range request, which slows > down a lot the entire http file transfer process or even time out. Applied. Thanks! > --- > grub-core/net/http.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/grub-core/net/http.c b/grub-core/net/http.c > index 4684f8b..a7c5101 100644 > --- a/grub-core/net/http.c > +++ b/grub-core/net/http.c > @@ -381,9 +381,8 @@ http_establish (struct grub_file *file, grub_off_t offset, int initial) > ptr = nb->tail; > grub_snprintf ((char *) ptr, > sizeof ("Range: bytes=XXXXXXXXXXXXXXXXXXXX-" > - "\r\n" > "\r\n"), > - "Range: bytes=%" PRIuGRUB_UINT64_T "-\r\n\r\n", > + "Range: bytes=%" PRIuGRUB_UINT64_T "-\r\n", > offset); > grub_netbuff_put (nb, grub_strlen ((char *) ptr)); > } >