From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1azKN8-0002Ah-EE for mharc-grub-devel@gnu.org; Sun, 08 May 2016 04:47:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azKN5-00025q-S2 for grub-devel@gnu.org; Sun, 08 May 2016 04:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azKN1-0001YU-JO for grub-devel@gnu.org; Sun, 08 May 2016 04:47:26 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:35886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azKN1-0001YE-BR for grub-devel@gnu.org; Sun, 08 May 2016 04:47:23 -0400 Received: by mail-lf0-x242.google.com with SMTP id y84so17904395lfc.3 for ; Sun, 08 May 2016 01:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=KqSLmqLQlh2krpGayZlI3j6Yg9c6zbw2CrNbAnwZYVM=; b=JfDAR52w8ytOyYxNEZKCLczRxXZcrtHEAFbMmYF8ziDmPVmVH2/ARTgNVqIiMhNVi6 XsSCOFAyQjvQ6TFU69CCI8N3CxkYKzQie41qmEX7GslxCDNVn8XydrwYmqdAbUxo5v5X BShVTGsfNHwBcSvDY19fwV4xAHn2VVRBJ7Oc1DHHu4JygKLYQZL0gDBLekljGzTgGDOL 7Nd49Aq9BUfb5lf3x3ZWPpwkFeVdOkf8YvsAOjwbZDvdW5HZ6FrXmzRVWmUoY3OKjhw0 ZNNv9w6mqdrisDj70n6Pnd5b92nb3R5ZVJsMcKIcIWrdAn+HvNL5mwT9PED1orRJM0yL Ld6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=KqSLmqLQlh2krpGayZlI3j6Yg9c6zbw2CrNbAnwZYVM=; b=QsrI9/t3ZNEb7Xb3Vdxo7gj/0H26gLiF8A6Itycb35SGqN4KvXxkNPyFKLq4euZFY/ LRzgCtkONMj/wEKKwfmGsh91hbzE1ZG4o6Iruxl8qvXAzxKQZDzT6j8tiZJ326ystty8 iqvKA1B9Xp9DhJG0TjUD+b7Cdje8zDKMMY9u5R7jJxjtCxp2eqcNODYxN/tfGMJAOFUo 4Q0dKeP3MkedpOx6CusZoxwVKi4jRn5K/H5VuiykF4z1fAWDgu1DyF7OhqS01c8AfVvG 3NG8QdSh+AiMBidbpoOHfiBcaGIJoKlIAoDIRLio3u6EyagwYh9oKw8IneANSFE5xAXd gXrg== X-Gm-Message-State: AOPr4FXk1mf5/mo5Q3fhpp2MHQfeag2nWL1V/nZHNClM9FaREHZiVn9PZOjlxVRFSXEIqg== X-Received: by 10.25.38.69 with SMTP id m66mr12633188lfm.64.1462697242343; Sun, 08 May 2016 01:47:22 -0700 (PDT) Received: from [192.168.1.42] (ppp109-252-90-74.pppoe.spdop.ru. [109.252.90.74]) by smtp.gmail.com with ESMTPSA id h9sm4236150lfg.3.2016.05.08.01.47.21 for (version=TLSv1/SSLv3 cipher=OTHER); Sun, 08 May 2016 01:47:21 -0700 (PDT) Subject: Re: [PATCH] Install to LVM PVs To: The development of GNU GRUB References: <572ED720.30800@gmail.com> From: Andrei Borzenkov Message-ID: <572EFD18.5070009@gmail.com> Date: Sun, 8 May 2016 11:47:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <572ED720.30800@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::242 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 May 2016 08:47:29 -0000 08.05.2016 09:05, Andrei Borzenkov пишет: >> >> +#ifdef GRUB_UTIL >> +int >> +grub_util_is_lvm(grub_disk_t disk) >> +{ >> + struct grub_diskfilter_pv_id id; >> + struct grub_diskfilter_vg *vg; >> + grub_disk_addr_t start_sector; >> + vg = grub_lvm_detect(disk, &id, &start_sector); >> + if (! vg) >> + return 0; >> + /* don't free the vg, it's held by grub_diskfilter_vg_register */ >> + grub_free(id.uuid); >> + return 1; >> +} >> + > > This has side effect of adding duplicate VG definitions; this may later > confuse grub. What about just checking array->driver for LVM? Go through > registered arrays, find disk match and check array driver. See > scan_disk_partition_iter () for example. > Which is basically call grub_diskfilter_get_pv_from_disk() and check vg_out->driver.