From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1azeM7-0004DN-4Y for mharc-grub-devel@gnu.org; Mon, 09 May 2016 02:07:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azeM0-00044g-JW for grub-devel@gnu.org; Mon, 09 May 2016 02:07:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azeLx-00035A-6G for grub-devel@gnu.org; Mon, 09 May 2016 02:07:40 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azeLw-00034K-SR for grub-devel@gnu.org; Mon, 09 May 2016 02:07:37 -0400 Received: by mail-lf0-x244.google.com with SMTP id y84so20047989lfc.3 for ; Sun, 08 May 2016 23:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=8KhYnVoo7Kz443DOMV3kAFPARRy1ZnksCnPwog5yJwA=; b=rEE+rDLS4Hba68RKpTR0+zT4FcwaNQYu6lPSAzNvgCWZ/nKpKQ/595N5+XnrvIhbwX v/WnClDG2GbPED7A7V1YcAWOw5F5V1aol4FbuNepIn2DRA6YvSKV9eTbUCz7+APNOY3u 8weNC2Ge9M5ZCoAWOszOsPxFUxWzhlNYaXG4nn+yX82GbIfot1VAxfNXrE8zqn6Tn126 KzM5ekURYZtMz/cvyFVmJCQ/DBLZF7g8mnXNhL3H22xmuiZZlLe1DdJtk3ysScjlbvjq fdgTCgZwQ2pIgvr+KxroD2peExj2F4lqb0/fPqVjDjnEs3Yi3JuLVxtJ5NRMCYXFPwUR XDjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=8KhYnVoo7Kz443DOMV3kAFPARRy1ZnksCnPwog5yJwA=; b=L9l40VFNl6P8KsdzPzcVYOnsgKnZVih7HFTNEsAha77UmIxTHuc/4+cKlrgGJoKa8u SH0gKM8jErrX5pZmaGsGhaTjJbJrU6rS2n0I2Wlt3ydR6twRYqAuoBXqHoGH/FXs2mUl B9LW6tRWBLWMx1bU94ZMs1/EPgvdOxvxnJCpZ1W5SPyIerXOHJDzytVhN+KPGHjkNNlM ekg8cxyYLcefCBcnm+bwb297M/XvYDStBXpqRi6tTvlQkcdX/Ypk0H29gP+PjspspIMj snJh/pzMO7KP7D7NleB0hTfe4HllE/MVXxSHsdsRl+tyR1p36dllzE5QvMLCPpgvcF9h +gJg== X-Gm-Message-State: AOPr4FUi3QInwhQyuqrXntgQqjvlBiRchiInZZDQD94eTzRPWSX7BuXbR6SWRGotKjw2Gg== X-Received: by 10.112.144.168 with SMTP id sn8mr13873650lbb.65.1462774055830; Sun, 08 May 2016 23:07:35 -0700 (PDT) Received: from [192.168.1.42] (ppp109-252-90-74.pppoe.spdop.ru. [109.252.90.74]) by smtp.gmail.com with ESMTPSA id e78sm4266290lfb.6.2016.05.08.23.07.34 for (version=TLSv1/SSLv3 cipher=OTHER); Sun, 08 May 2016 23:07:34 -0700 (PDT) Subject: Re: [PATCH] Install to LVM PVs To: The development of GNU GRUB References: <572ED720.30800@gmail.com> From: Andrei Borzenkov Message-ID: <57302925.2000000@gmail.com> Date: Mon, 9 May 2016 09:07:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::244 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 06:07:45 -0000 08.05.2016 16:01, Dryden Personalis пишет: > >>> - if (fs_probe) >>> + if (!is_lvm && fs_probe) >> >> No, we want to probe for FS here to eliminate corner case of both PV and >> FS metadata. > > You mean you want to change it to: > No, I do not want to change it at all. It should remain as is and always probe for FS so that test below actually works ... >> And you need to add check for LVM here >> >> if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || (is_ldm >> && fs)) > > I take it you mean: > > if (!is_lvm && (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || > (is_ldm && fs))) > I mean if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || ((is_ldm || is_lvm) && fs))