From: Pete Batard <pete@akeo.ie>
To: grub-devel@gnu.org
Subject: [PATCH] Add missing va_end() to xasprintf() in grub-emu
Date: Sat, 13 Aug 2016 10:54:27 +0200 [thread overview]
Message-ID: <57AEE043.4010600@akeo.ie> (raw)
[-- Attachment #1: Type: text/plain, Size: 109 bytes --]
Hi,
I believe there's an unbalanced va_start/va_end pair in grub-emu.
This patch fixes it.
Regards,
/Pete
[-- Attachment #2: Add-missing-va_end-to-xasprintf-in-grub-emu.patch --]
[-- Type: text/plain, Size: 665 bytes --]
From 0ed65abd009b79955c8578bfb40cc33e51e463ae Mon Sep 17 00:00:00 2001
From: Pete Batard <pete@akeo.ie>
Date: Sat, 13 Aug 2016 10:51:34 +0200
Subject: [PATCH] Add missing va_end() to xasprintf() in grub-emu.
---
grub-core/kern/emu/misc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/grub-core/kern/emu/misc.c b/grub-core/kern/emu/misc.c
index d361feb..7666133 100644
--- a/grub-core/kern/emu/misc.c
+++ b/grub-core/kern/emu/misc.c
@@ -127,6 +127,7 @@ xasprintf (const char *fmt, ...)
va_start (ap, fmt);
result = grub_xvasprintf (fmt, ap);
+ va_end (ap);
if (!result)
grub_util_error ("%s", _("out of memory"));
--
2.8.1.windows.1
next reply other threads:[~2016-08-13 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 8:54 Pete Batard [this message]
2016-08-13 13:36 ` [PATCH] Add missing va_end() to xasprintf() in grub-emu Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AEE043.4010600@akeo.ie \
--to=pete@akeo.ie \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).