From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Cc: Andrey Borzenkov <arvidjaar@gmail.com>
Subject: Re: [PATCH] multistring support in gui_label
Date: Wed, 17 Apr 2013 10:56:26 +0400 [thread overview]
Message-ID: <6699378.0O6bOZlDYk@icedphoenix> (raw)
In-Reply-To: <20130416211023.34876656@opensuse.site>
On Tuesday, April 16, 2013 09:10:23 PM Andrey Borzenkov wrote:
> > +/* Differs from grub_font_draw_line only in multiline output */
>
> You mean grub_font_draw_string? Is it possible to extend this function
> instead of duplicating it?
Hmmm... I'll think through it. Would it be wise? The sets of parameteres in
these two functions are very different and the code is totally different...
> All nested functions were removed from trunk. Please do not reintroduce
> them. This should not even compile.
My fault. Made the patch for grub-2.00, and forgot to remade it for upstream
version. I've noticed that nested functions were removed. I will remake it
soon.
I've included the patch more for seeing the idea. It is not complete and (I
think) shouldn't be included in the upstream until two problems, I've
mentioned in previous letter, are not fixed. :)
Thank for the reply.
--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
next prev parent reply other threads:[~2013-04-17 6:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 9:04 [PATCH] multistring support in gui_label Vladimir Testov
2013-04-16 17:10 ` Andrey Borzenkov
2013-04-17 6:56 ` Vladimir Testov [this message]
2013-04-17 7:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-17 9:02 ` Vladimir Testov
2013-04-17 11:16 ` Vladimir Testov
2013-04-17 11:39 ` Vladimir Testov
2013-04-17 12:41 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-23 11:58 ` Vladimir Testov
2013-04-23 16:26 ` [RFC][PATCH] " Vladimir Testov
-- strict thread matches above, loose matches on Subject: below --
2013-03-22 15:58 [PATCH] " Vladimir Testov
2013-04-03 7:20 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-03-21 17:17 Vladimir Testov
2013-03-21 18:12 ` Gerard Butler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6699378.0O6bOZlDYk@icedphoenix \
--to=vladimir.testov@rosalab.ru \
--cc=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).