grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: grub-devel@gnu.org
Subject: Re: [PATCH] F2FS support
Date: Sat, 31 Mar 2018 22:47:29 +0200	[thread overview]
Message-ID: <7b880435b17b172ac3d562203a0a5ceddeebb726.camel@users.sourceforge.net> (raw)
In-Reply-To: <a9f0a1a6-4dc2-bed2-0bd3-b613e1c0a857@akeo.ie>

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Dear Pete,


Am Donnerstag, den 29.03.2018, 17:08 +0100 schrieb Pete Batard:
> Thanks for reviewing the patch.
> Here's a v2 that takes your comments into account.

Could you please make the commit message title a statement by adding a
verb?

> Add F2FS support

Could you additionally add an example to the commit message, how to
test the support with QEMU? That would help me, test your patch.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2018-03-31 20:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 16:47 [PATCH] F2FS support Pete Batard
2018-03-28 12:04 ` Daniel Kiper
2018-03-29 16:08   ` Pete Batard
2018-03-31 20:47     ` Paul Menzel [this message]
2018-04-01 19:16       ` Pete Batard
2018-04-04 21:03       ` Daniel Kiper
2018-04-04 20:37     ` Daniel Kiper
2018-04-04 21:11       ` Pete Batard
  -- strict thread matches above, loose matches on Subject: below --
2018-03-17  9:08 林博仁
2018-03-18 20:39 ` Pete Batard
2018-03-22 14:26   ` Daniel Kiper
2017-05-04 18:12 Jaegeuk Kim
2017-05-04 20:52 ` Adam Borowski
2015-03-24  8:19 Jaegeuk Kim
2015-03-28  7:31 ` Andrei Borzenkov
2015-03-28 20:43   ` Jaegeuk Kim
2015-03-28 21:00     ` Andrei Borzenkov
2015-04-03 22:48   ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b880435b17b172ac3d562203a0a5ceddeebb726.camel@users.sourceforge.net \
    --to=paulepanter@users.sourceforge.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).