From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f2NPa-0002Eo-L0 for mharc-grub-devel@gnu.org; Sat, 31 Mar 2018 16:47:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2NPX-0002EK-6o for grub-devel@gnu.org; Sat, 31 Mar 2018 16:47:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2NPW-0000Sc-Fq for grub-devel@gnu.org; Sat, 31 Mar 2018 16:47:39 -0400 Received: from mail.gw90.de ([2a01:4f8:140:71f5::3]:36904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2NPW-0000SK-9P for grub-devel@gnu.org; Sat, 31 Mar 2018 16:47:38 -0400 Received: from [2a02:8109:b5bf:f806:2d1f:41f7:fba1:a29f] (helo=mattotaupa) by mail.gw90.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f2NPU-0005GE-NV for grub-devel@gnu.org; Sat, 31 Mar 2018 20:47:36 +0000 Message-ID: <7b880435b17b172ac3d562203a0a5ceddeebb726.camel@users.sourceforge.net> Subject: Re: [PATCH] F2FS support From: Paul Menzel To: grub-devel@gnu.org Date: Sat, 31 Mar 2018 22:47:29 +0200 In-Reply-To: References: <76ef281d-68e7-6e0f-5607-ea6eb82c5949@akeo.ie> <20180328120452.GB31516@router-fw-old.local.net-space.pl> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-biC2OzEjGWTvOHuzFX7O" X-Mailer: Evolution 3.28.0-3 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:140:71f5::3 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2018 20:47:41 -0000 --=-biC2OzEjGWTvOHuzFX7O Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Pete, Am Donnerstag, den 29.03.2018, 17:08 +0100 schrieb Pete Batard: > Thanks for reviewing the patch. > Here's a v2 that takes your comments into account. Could you please make the commit message title a statement by adding a verb? > Add F2FS support Could you additionally add an example to the commit message, how to test the support with QEMU? That would help me, test your patch. Thanks, Paul --=-biC2OzEjGWTvOHuzFX7O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQ8+w9d414FAVARIpk9fVorbA4dWAUCWr/z4gAKCRA9fVorbA4d WFIRAJ48K0AgFg63y1poLydSwT44+JUV+gCfaciB3ykkA3az4T6xv6OpKOSmpaU= =nT6o -----END PGP SIGNATURE----- --=-biC2OzEjGWTvOHuzFX7O--