From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kRofq-0003kC-Mf for mharc-grub-devel@gnu.org; Sun, 11 Oct 2020 23:38:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRofp-0003k3-Kz for grub-devel@gnu.org; Sun, 11 Oct 2020 23:38:57 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:33772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kRofn-00036w-Ue for grub-devel@gnu.org; Sun, 11 Oct 2020 23:38:57 -0400 Received: by mail-pl1-x62d.google.com with SMTP id b19so7871120pld.0 for ; Sun, 11 Oct 2020 20:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=K8Fd3s47w2ft+BtyU8UhhKuCAD00xH96CU57Dow7oxI=; b=C7IxwQdQ8PDeSDQ5fXX7OJ4xVPIzK0hXTmcr/ijQkVrOwErdPYyZPywqN63Jp81sa4 h/P26G/CcNcF5T2irzXAHKoHa4Ah7BGR3gwGm53i331vJv6AHaQFWJhVPVI29L4YSLXo 1c/655/g2rhZzWpyGfLEp5CYxfa2JJ98dTwJI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=K8Fd3s47w2ft+BtyU8UhhKuCAD00xH96CU57Dow7oxI=; b=HFpjrWV0bYYcNsrvs7a2bqqmMW+Pnsb1q4djvR2DysAKSU4BSMGFGxKDw2r0k4Ct8H nIf70yF7zhldBXhrPF7PeeimFtpp+qrs7Cxur23iBXENi7mtK9vqPPgqSOLvzF6rhL+m YpvUfvwdjfe23qBtfSIUbKa7RVMbAyu65S7NpSZn8qI33C0K11lk83qx7HGqPf0him2G q6YDHlvCpEzAD+RmctvibLmC5a4WupAlsMZRDoT+Sz0ou9PsoV4CRcVAqlDjVbHK0aMT 2ORqYLDGb4o+3InRCzxJnV+YqozwUQ/bFPUoaJTpljXGyQk3WCDKvwdygBJnhpLAtd5C 9IaQ== X-Gm-Message-State: AOAM531g83PlZHiHSVOYoMLGhx5sFsHUtn0kf3HYbBtqTJUhT774By0F a/X2Hm/+eZRLiJNMGzqKFGRI6diR3YpRlA== X-Google-Smtp-Source: ABdhPJyWQ66gBa+8HEg8+L8WqhctSDAR2zl3LPkUkWVH+uYi3ZlZfhyJ+ZmtxS9azaCBTRHoVD2e8A== X-Received: by 2002:a17:902:9347:b029:d3:b2c6:1500 with SMTP id g7-20020a1709029347b02900d3b2c61500mr22588945plp.5.1602473933655; Sun, 11 Oct 2020 20:38:53 -0700 (PDT) Received: from localhost (2001-44b8-1113-6700-2428-55d4-1def-c9e5.static.ipv6.internode.on.net. [2001:44b8:1113:6700:2428:55d4:1def:c9e5]) by smtp.gmail.com with ESMTPSA id y16sm19040997pfb.154.2020.10.11.20.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2020 20:38:53 -0700 (PDT) From: Daniel Axtens To: grub-devel@gnu.org Cc: rashmica.g@gmail.com, alastair@d-silva.org Subject: Re: [PATCH 13/18] grub-install: support embedding x509 certificates In-Reply-To: <20201002051321.1538488-14-dja@axtens.net> References: <20201002051321.1538488-1-dja@axtens.net> <20201002051321.1538488-14-dja@axtens.net> Date: Mon, 12 Oct 2020 14:38:50 +1100 Message-ID: <87eem4w1th.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=dja@axtens.net; helo=mail-pl1-x62d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2020 03:38:57 -0000 > + case 'x': > + arguments->x509keys = xrealloc (arguments->x509keys, > + sizeof (arguments->x509keys[0]) > + * (arguments->nx509keys + 1)); > + arguments->pubkeys[arguments->nx509keys++] = xstrdup (arg); This should be arguments->x509keys[]. I will fix this in v2. (We caught this internally but I failed to apply the fix to my tree before sending it out!) Kind regards, Daniel